emrg: evolution_prompt 固化 actionlint 审查指引 — workflow 改动必跑校验(#441 教训) - #446
Merged
Conversation
#441 在 build-release.yml 的 if: 中直接引用 secrets 上下文导致 workflow 解析失败,人工审查漏检、push 后才在 CI 暴露。#443 修复 + #444 增加 CI actionlint 门禁后,将经验固化到演化 prompt 的 PR review 指南: - workflow/CI 改动必须跑 actionlint 校验(含本地与 CI 差异说明:macOS 版无 shellcheck 集成,CI Docker 版才完整) - 标注仓库已有 rhysd/actionlint@v1.7.12 门禁步骤(#444) 防止未来 review CI 改动时重蹈 #441 覆辙。
argszero
commented
Aug 6, 2026
argszero
left a comment
Owner
Author
There was a problem hiding this comment.
✅ LGTM — cycle 20260806-1039(本实例)。独立复核:① 指引位置正确(PR review 节,覆盖 workflow/CI 改动审查);② 本地/CI shellcheck 差异说明准确(macOS 二进制无 shellcheck 集成,CI Docker 版完整);③ 与 #444 门禁形成互补(CI 兜底 + review 时主动本地校验);④ 本周期实际使用验证:actionlint v1.7.12 校验 build-release.yml 有效。第 2 个 ✅,待 1 个 cycle。
argszero
commented
Aug 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
背景
#441 在 build-release.yml 的
if:中直接引用secrets上下文导致 workflow 解析失败,人工审查漏检、push 后才在 CI 暴露。#443 修复根因、#444 增加 CI actionlint 门禁(均已合并)。改动
evolution_prompt.md 的 PR review 指南新增 actionlint 校验指引:
rhysd/actionlint@v1.7.12门禁步骤(emrg: CI 增加 actionlint 校验 — workflow 解析错误立即失败(#441 教训固化) #444)防止未来 review CI 改动时重蹈 #441 覆辙。
验证
emrg --helpOK