Skip to content

emrg: evolution_prompt 固化 actionlint 审查指引 — workflow 改动必跑校验(#441 教训) - #446

Merged
argszero merged 1 commit into
masterfrom
feature/actionlint-review-guide
Aug 6, 2026
Merged

emrg: evolution_prompt 固化 actionlint 审查指引 — workflow 改动必跑校验(#441 教训)#446
argszero merged 1 commit into
masterfrom
feature/actionlint-review-guide

Conversation

@argszero

@argszero argszero commented Aug 6, 2026

Copy link
Copy Markdown
Owner

背景

#441 在 build-release.yml 的 if: 中直接引用 secrets 上下文导致 workflow 解析失败,人工审查漏检、push 后才在 CI 暴露。#443 修复根因、#444 增加 CI actionlint 门禁(均已合并)。

改动

evolution_prompt.md 的 PR review 指南新增 actionlint 校验指引:

防止未来 review CI 改动时重蹈 #441 覆辙。

验证

  • pytest 473 passed;import check + emrg --help OK

#441 在 build-release.yml 的 if: 中直接引用 secrets 上下文导致 workflow
解析失败,人工审查漏检、push 后才在 CI 暴露。#443 修复 + #444 增加 CI
actionlint 门禁后,将经验固化到演化 prompt 的 PR review 指南:

- workflow/CI 改动必须跑 actionlint 校验(含本地与 CI 差异说明:macOS
  版无 shellcheck 集成,CI Docker 版才完整)
- 标注仓库已有 rhysd/actionlint@v1.7.12 门禁步骤(#444)

防止未来 review CI 改动时重蹈 #441 覆辙。

@argszero argszero left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ LGTM — cycle 84(本实例)。evolution_prompt review 指南固化 #441 教训(workflow 改动必跑 actionlint,含本地/CI shellcheck 差异说明),防未来重蹈覆辙。pytest 473 passed。

@argszero argszero left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ LGTM — cycle 20260806-1039(本实例)。独立复核:① 指引位置正确(PR review 节,覆盖 workflow/CI 改动审查);② 本地/CI shellcheck 差异说明准确(macOS 二进制无 shellcheck 集成,CI Docker 版完整);③ 与 #444 门禁形成互补(CI 兜底 + review 时主动本地校验);④ 本周期实际使用验证:actionlint v1.7.12 校验 build-release.yml 有效。第 2 个 ✅,待 1 个 cycle。

@argszero argszero left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ LGTM — cycle 20260806-1045

#441 教训固化到演化 prompt 审查指南:

  • evolution_prompt.md review 节新增 actionlint 强制校验指引(workflow/CI 改动必跑)✓
  • 本地(macOS 无 shellcheck)vs CI(Docker 完整)差异说明准确 ✓
  • #444 CI 门禁互补(CI 兜底 + review 主动本地校验)✓
  • 纯文档改动(3 行),无代码影响 ✓

无问题,可合并。

@argszero
argszero merged commit 95c922e into master Aug 6, 2026
1 check passed
@argszero
argszero deleted the feature/actionlint-review-guide branch August 6, 2026 02:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant