emrg: 签名/公证验证严格化 — pkgutil 强制成功 + notarytool --timeout 20m(rant P3 补完) - #448
Merged
Conversation
argszero
commented
Aug 6, 2026
argszero
left a comment
Owner
Author
There was a problem hiding this comment.
✅ LGTM — cycle 20260806-1102
签名/公证验证严格化(rant P3 补完)审查:
- pkgutil --check-signature 去 || true → 签名后验证强制成功(符合 rant 验收"显示 signed by Developer ID")✓
- notarytool submit 加 --timeout 20m(设计文档 §4.4 明确要求,默认 10m 在 Apple 公证高峰可能超时)✓
- 无 if:secrets(沿用 job env 模式)、actionlint 全绿、YAML OK ✓
- 降级行为不变(无证书路径两 step 跳过)✓
- CI test pass(1m0s)✓
无问题,可合并。
argszero
commented
Aug 6, 2026
argszero
left a comment
Owner
Author
There was a problem hiding this comment.
✅ LGTM — cycle 20260806-1105
第 2 个独立周期确认(1102 → 1105):
- pkgutil --check-signature 去 || true → 签名验证强制成功(rant 验收)✓
- notarytool --timeout 20m(设计文档 §4.4)✓
- 无 if:secrets、actionlint 全绿、CI pass ✓
- 降级行为不变 ✓
无问题,可合并。
argszero
commented
Aug 6, 2026
argszero
left a comment
Owner
Author
There was a problem hiding this comment.
✅ LGTM — cycle 85(本实例)。P3 验证严格化合理:① pkgutil --check-signature 去掉 || true——签名存在时(Secret 已配)验证必须成功,符合 rant 验收;② notarytool 加 --timeout 20m——设计文档 §4.4 明确要求,默认 10m 在 Apple 排队高峰可能不足。无新 shellcheck 问题,CI 门禁会兜底。可合并。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
背景
rant 2026-08-06T10:06:55 P3(验证)补完。对照权威设计文档 docs/design/macos-signing.md 复核 #441/#445 实现,发现两处差异:
改动(.github/workflows/build-release.yml,+4/-3)
|| true:Sign pkg step 仅在证书存在时执行(if: env.MACOS_SIGNING_IDENTITY != ''),签名后验证应强制成功(rant 验收项:显示signed by Developer ID)——|| true使验证形同虚设--timeout 20m:设计文档 §4.4 明确要求。notarytool 默认超时 600s,Apple 公证排队高峰可能超过 → CI 失败;20m 与设计一致验证
emrg --helpOK(无 Python 改动)影响