Skip to content

emrg: evolution_prompt review 指南补充 — 验证类逻辑需正反两态验证（#455 教训） #458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
argszero merged 1 commit into from
Aug 6, 2026
Merged

emrg: evolution_prompt review 指南补充 — 验证类逻辑需正反两态验证（#455 教训） #458

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions emrg/server/evolution_prompt.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,7 @@ cd {{ source_dir }} && gh pr list -R {{ owner }}/{{ repo }} --limit 20
- **⚡ workflow/CI 改动必须跑 actionlint 校验**（#441 教训：build-release.yml 的 `if:` 中直接引用 `secrets` 上下文导致 workflow 解析失败，人工审查漏检、push 后才在 CI 暴露）：
- 本地校验：`actionlint .github/workflows/*.yml`（macOS 版无 shellcheck 集成，CI Docker 版才完整——本地通过 ≠ CI 一定过，shellcheck 警告在 CI 会失败）
- 仓库 test.yml 已有 `rhysd/actionlint@v1.7.12` 门禁步骤（#444 固化，全量校验所有 workflow），但 review CI 改动时仍应主动本地跑一遍确认
- **⚡ 验证类逻辑（检查/检测/grep 条件）必须在正反两态都验证**（#455 教训：review 时从"失败数据"推断检查逻辑，`grep -c 'class: 0x0000000F'` 数私钥——实测 0x0000000F 是属性 ID 非 class 行，含私钥时返回 0 → 宿主修复后误报失败；正确方法解析 `security import` 输出的 `identity imported` 判别信号，#456 修正）。审查此类改动时：**在成功场景与失败场景各跑一遍确认判别信号可靠**，不能只在失败案例上推断。
- 检查合并条件：PR 的 comment 历史中是否已有连续 3 个不同 cycle 的 ✅ 且中间无 ❌？
- ⚠️ 查询评论用 REST API（GraphQL 需 `read:org` scope，token 常缺）：
`gh api repos/{{ owner }}/{{ repo }}/issues/<N>/comments --jq '.[] | "\(.user.login): \(.body)"'`
Expand Down
Loading