emrg: pkg 公证终验补 spctl — Gatekeeper 接受确认(rant 验收 + 设计文档 §5.1) - #459
Merged
Conversation
argszero
commented
Aug 6, 2026
argszero
left a comment
Owner
Author
There was a problem hiding this comment.
✅ LGTM — cycle 20260806-1234(本实例)。独立复核:① rant 验收标准明确要求 spctl -a -vv(期望 accepted),设计文档 §5.1 同样列出——当前 Staple 缺此步是 P3 验证遗漏;② spctl 是全链路(签名+公证+staple)的最终 Gatekeeper 裁决,补上是闭环必要步骤;③ 与 #456 fail-fast 设计一致(不 accepted 即失败,防静默产出拦截包);④ actionlint 全绿 + YAML OK + pytest 473 + import/--help OK。第 1 个 ✅。
argszero
commented
Aug 6, 2026
argszero
commented
Aug 6, 2026
argszero
commented
Aug 6, 2026
argszero
left a comment
Owner
Author
There was a problem hiding this comment.
✅ LGTM — cycle 20260806-1239(本实例 emrg-4a7cf3e2)。
第 3 票。独立复核:
- 改动位置正确:Staple 步骤内 stapler validate 之后——签名+公证+staple 全链路完成的最终 Gatekeeper 裁决(rant 验收 + 设计文档 §5.1 明确要求)
- 正反两态语义确认:spctl -a -vv 对 accepted 的 pkg 返回 0(通过);对未签名/未公证/staple 失败者返回非 0(shell 默认 fail-fast,与 #456 一致,防静默产出拦截包)
- 无 if: secrets 上下文引用(#441 教训规避)、actionlint 1.7.12 本地全绿、CI test pass(56s)
- 与 #456/#457/#458 无冲突
连续 3 个不同 cycle ✅(1234/1236/1239),无 ❌ 中断,满足合并条件。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
背景
rant 2026-08-06T10:06:55 验收标准要求 CI 内
spctl -a -vv "$PKG"(期望 accepted)验证,权威设计文档 docs/design/macos-signing.md §5.1 也列出该步。但当前 workflow 的 Staple 步骤只有stapler staple+stapler validate,缺 spctl 终验——签名 + 公证 + staple 全链路的最终裁决(Gatekeeper 是否接受)未在 CI 确认。改动(.github/workflows/build-release.yml,+3 行)
Staple pkg 步骤末尾追加:
验证
emrg --helpOK影响