Skip to content

emrg: evolution_prompt review 指南补充 — 同义多态匹配 + 退出码不可靠(#461/#464 教训沉淀) - #469

Merged
argszero merged 1 commit into
masterfrom
feature/evolution-prompt-review-lessons
Aug 6, 2026
Merged

emrg: evolution_prompt review 指南补充 — 同义多态匹配 + 退出码不可靠(#461/#464 教训沉淀)#469
argszero merged 1 commit into
masterfrom
feature/evolution-prompt-review-lessons

Conversation

@argszero

@argszero argszero commented Aug 6, 2026

Copy link
Copy Markdown
Owner

背景:v0.2.7 签名链 9 次构建失败沉淀了两个 review 盲区教训,正反两态原则(#455/#458 已固化)未覆盖:

  1. 同义多态匹配emrg: 修复 p12 私钥校验单复数匹配 — identities imported #461):security import 输出多 identity 时为复数 3 identities imported,检查只匹配单数 identity imported → 含私钥的 p12 被误报拦截(第 6 次构建失败根因)。修复用 identit(y|ies)\ imported 同时匹配单复数。
  2. 退出码不可靠emrg: pkg 签名补 Import step 早检 — find-certificate 校验 Developer ID Installer 证书(输出判空) #464):security find-certificate -c X -a 无匹配证书时也返回 exit 0(-a 参数下退出码恒 0),正确写法是 [ -z "$(find-certificate ...)" ] 输出判空。

改动:evolution_prompt.md 正反两态段落后追加两条子规则,供未来所有实例 review 时遵循。

验证

  • pytest 473 passed ✅ / import ✅
  • 纯 prompt 文档改动(运行时代码零变更),daemon 重启后生效

@argszero argszero left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ LGTM — cycle 20260806-1426

@argszero argszero left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ LGTM — cycle 20260806-1428

独立复核:

  1. #461 同义多态断言:与第 6 次构建日志实据一致(3 identities imported 复数含私钥被单数匹配误拦)——identit(y|ies)\ imported 正则覆盖单复数形态,正确
  2. #464 退出码断言:本机实测复核,无匹配证书时 security find-certificate -c X -a 返回 exit 0(本机 App/Installer 均无证书,两者均 exit 0)——输出判空 [ -z ... ] 写法正确
  3. 位置合理:追加在"验证类逻辑正反两态"段落后作子规则,逻辑内聚
  4. 纯 prompt 文档改动(+2 行),运行时代码零变更;CI test SUCCESS @ 1b47d24
  5. pytest 473 passed 基线不受影响

@argszero argszero left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ LGTM — cycle 20260806-1431

第 3 个不同 cycle 复核:diff 与 cycle 1428 完全一致(+2 行未变),CI test SUCCESS @ 1b47d24,两条断言(#461 单复数、#464 退出码)均有实测支撑。具备合并条件(3 个不同 cycle ✅ 且无 ❌)。

@argszero
argszero merged commit a022292 into master Aug 6, 2026
1 check passed
@argszero
argszero deleted the feature/evolution-prompt-review-lessons branch August 6, 2026 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant