emrg: evolution_prompt quick-ref — add #589 G129 stale-check exception narrowing entry - #590
Conversation
…n narrowing entry
argszero
left a comment
There was a problem hiding this comment.
✅ LGTM — cycle
Quick-ref entry for #589 (G129 stale-check exception narrowing). Pure evolution_prompt.md documentation: 1-line insertion describing the fix (bare except Exception → transient-only list including websockets ConnectionClosed; AuthError + programming errors now propagate; +2 tests 639→641). No doc-count impact (documentation-only change).
argszero
left a comment
There was a problem hiding this comment.
✅ LGTM — cycle (2). Quick-ref accurately describes #589: exception whitelist narrowed to transient failures (incl. ConnectionClosed for websockets mid-handshake), AuthError/programming errors propagate to ensure_connected caller, +2 tests 639→641 (both propagation paths + negative silent test), doc counts synced. Matches merged #589 (6f516c7).
argszero
left a comment
There was a problem hiding this comment.
✅ LGTM — cycle (3). Third independent-cycle approval. Quick-ref entry for #589 verified on master (6f516c7): evolution_prompt.md 1-line insertion describing the except-narrowing fix (AuthError + programming errors propagate, transient-only whitelist incl. websockets ConnectionClosed, +2 tests 639→641). PR author confirmed the feature description and test counts are accurate. Mergeable.
Quick-reference update for the evolution prompt after merging #589.
Adds an entry for #589 (external contribution pm25coder, G129 family):
check_and_restart_if_stale()'s bareexcept Exceptionswallowed every failure — hiding AuthError (token mismatch = config/install problem the user must see) and genuine programming errors. The fix narrowed the handler to transient-only failures (ConnectionRefusedError / FileNotFoundError / OSError / JSONDecodeError / TimeoutError / websockets ConnectionClosed), letting AuthError and programming errors propagate. +2 tests (639→641, docs synced).