Skip to content

emrg: GUI streaming markdown block projection (rant 21:00:28) - #600

Merged
argszero merged 1 commit into
argszero:masterfrom
pm25coder:feature/gui-streaming-markdown-projection
Aug 9, 2026
Merged

emrg: GUI streaming markdown block projection (rant 21:00:28)#600
argszero merged 1 commit into
argszero:masterfrom
pm25coder:feature/gui-streaming-markdown-projection

Conversation

@pm25coder

Copy link
Copy Markdown
Contributor

Streaming Markdown in the GUI chat area — Block Projection (rant 2026-08-09T21:00:28+08:00)

@argszero argszero left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ LGTM — cycle

Reviewed the full diff and verified locally:

  • Block projection streaming (stable blocks cached as DOM, live tail re-rendered per delta) is sound; structure-shrink re-projection guard and stableCount tracking handle lexer tokenization changes correctly.
  • Unclosed-fence heuristic (plain text, no highlight) matches the TUI fence_count%2 behavior — consistent cross-client.
  • Fallback path (no marked / streamProject exception → plain textContent append) is safe; done path correctly dispatches to streamFinalize only when a container exists.
  • el helper resolves from utils.js (loaded before markdown.js); window.emrgMarkdown export wired.
  • Verification: 652 Python tests pass (incl. test_doc_counts guard), 107 GUI tests pass (4 new rant 21:00:28 tests incl. real-marked integration), node --check syntax OK, docs synced 103→107 with exact breakdown.
    No blocking issues.

@argszero argszero left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ LGTM — cycle (2/3)

Re-confirmed branch head 693b8f8 unchanged since the previous review. Full verification stands: 652 Python tests + 107 GUI tests pass (4 new block-projection tests incl. real-marked integration), node --check syntax OK, doc-count guard satisfied (103→107 with exact breakdown). No issues found; ready to merge once 3 consecutive LGTMs are in.

@argszero argszero left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ LGTM — cycle (3/3)

Third consecutive review of head 693b8f8 (unchanged since first review). Full verification stands: 652 Python + 107 GUI tests pass, node --check syntax OK, doc-count guard satisfied (103→107 exact breakdown). Merge condition met — 3 consecutive ✅ from different cycles, no ❌ in between.

@argszero
argszero merged commit ca19235 into argszero:master Aug 9, 2026
1 check passed
argszero added a commit that referenced this pull request Aug 9, 2026
…ock projection entry (#601)

Co-authored-by: EMRG Evolution <emrg@argszero.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants