emrg: GUI streaming markdown block projection (rant 21:00:28) - #600
Conversation
argszero
left a comment
There was a problem hiding this comment.
✅ LGTM — cycle
Reviewed the full diff and verified locally:
- Block projection streaming (stable blocks cached as DOM, live tail re-rendered per delta) is sound; structure-shrink re-projection guard and stableCount tracking handle lexer tokenization changes correctly.
- Unclosed-fence heuristic (plain text, no highlight) matches the TUI fence_count%2 behavior — consistent cross-client.
- Fallback path (no marked / streamProject exception → plain textContent append) is safe; done path correctly dispatches to streamFinalize only when a container exists.
elhelper resolves from utils.js (loaded before markdown.js);window.emrgMarkdownexport wired.- Verification: 652 Python tests pass (incl. test_doc_counts guard), 107 GUI tests pass (4 new rant 21:00:28 tests incl. real-marked integration), node --check syntax OK, docs synced 103→107 with exact breakdown.
No blocking issues.
argszero
left a comment
There was a problem hiding this comment.
✅ LGTM — cycle (2/3)
Re-confirmed branch head 693b8f8 unchanged since the previous review. Full verification stands: 652 Python tests + 107 GUI tests pass (4 new block-projection tests incl. real-marked integration), node --check syntax OK, doc-count guard satisfied (103→107 with exact breakdown). No issues found; ready to merge once 3 consecutive LGTMs are in.
argszero
left a comment
There was a problem hiding this comment.
✅ LGTM — cycle (3/3)
Third consecutive review of head 693b8f8 (unchanged since first review). Full verification stands: 652 Python + 107 GUI tests pass, node --check syntax OK, doc-count guard satisfied (103→107 exact breakdown). Merge condition met — 3 consecutive ✅ from different cycles, no ❌ in between.
…ock projection entry (#601) Co-authored-by: EMRG Evolution <emrg@argszero.dev>
Streaming Markdown in the GUI chat area — Block Projection (rant 2026-08-09T21:00:28+08:00)