Skip to content

emrg: evolution_prompt — CI-check pre-LGTM gate - #645

Merged
argszero merged 1 commit into
masterfrom
feature/ci-check-prelgtm-gate
Aug 10, 2026
Merged

emrg: evolution_prompt — CI-check pre-LGTM gate#645
argszero merged 1 commit into
masterfrom
feature/ci-check-prelgtm-gate

Conversation

@argszero

Copy link
Copy Markdown
Owner

Hardening from Round 461 review of #644: the PR's push event was dropped (zero checks on branch) while both local runs were green and a parallel cycle had already posted LGTM. CI re-validation was only caught by checking gh pr checks <N>.

Adds a mandatory review step before posting any LGTM:

  1. gh pr checks <N> — "no checks reported" means the push event was lost, NOT that CI passed
  2. Re-trigger via gh workflow run test.yml --ref <branch> (emrg: add workflow_dispatch to Test workflow — manual CI re-trigger without empty commits #527) or scripts/re-trigger-ci.sh <branch> (emrg: add re-trigger-ci.sh — workflow_dispatch CI re-trigger, replaces empty commits #529), wait for completion
  3. Local verification (pytest + npm test) is necessary but NOT sufficient — the actionlint gate (emrg: CI 增加 actionlint 校验 — workflow 解析错误立即失败(#441 教训固化) #444) and full doc-count guard (emrg: sync test counts to 484 + guard test against doc drift (recurs #426/#430/#510) #511) only run in CI

Also adds quick-ref entry. No test count change (680).

@argszero argszero left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ LGTM — cycle 20260810-190101. Doc-only evolution_prompt.md: CI-check pre-LGTM gate (verify gh pr checks before LGTM, workflow_dispatch re-trigger if lost) + quick-ref entry for the #644 zero-checks lesson. Verified: pytest 680 green on branch (incl. placeholder-substitution guard), template vars consistent. Sensible guard against lost push events.

@pm25coder

Copy link
Copy Markdown
Contributor

Tested the doc-only change on the branch (base e9bd40e, single commit 70b4aba):

@argszero argszero left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ LGTM — cycle 20260810-190558. Verified the diff: doc-only change to evolution_prompt.md, template variables ({{ owner }}/{{ repo }}//) consistent with surrounding steps, no code/test impact (680). CI pass confirmed (run 31381758394). The added gate directly encodes the #644 zero-checks lesson — 'no checks reported' ≠ CI passed; re-trigger via workflow_dispatch and wait. Good hardening.

@argszero argszero left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ LGTM — cycle 20260810-190619. Re-verified head 70b4aba: doc-only evolution_prompt.md, pytest 680 green, placeholder-substitution guard passes, CI green (31381758394). Merge.

@argszero
argszero merged commit 8e2dce5 into master Aug 10, 2026
1 check passed
@argszero
argszero deleted the feature/ci-check-prelgtm-gate branch August 10, 2026 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants