emrg: remove non-stream dead code — _run_chat_once / TaskRequest.stream (rant 2026-08-10T21:20:38)

[argszero]

Remove the non-streaming single-turn chat path, which no client uses (host-confirmed dead code).

Background

While designing the queue-injection feature (tool loop in progress + new message), the daemon's non-stream path (req.stream=False → _run_chat_once) was found to be unused:

• GUI sendTask always defaults stream=true (emrg/gui/daemon_client.js)
• TUI always sends stream=True (emrg/client/app.py)
• No client ever uses the non-stream branch

Host confirmed: delete dead code, do not keep unused code.

Changes

1. Delete _run_chat_once (daemon.py) — non-streaming single-turn chat
2. Delete _run_chat_once_locked (daemon.py) — its lock wrapper
3. Task handling always routes through _run_tool_loop_locked — removed the if req.stream: branch
4. Drop TaskRequest.stream field (emrg/protocol.py) — field + to_dict() entry removed
5. Client sync:
   • GUI sendTask: removed stream param + payload field; ownStream lock now set unconditionally
   • TUI send_task: removed stream param; call site cleaned
6. Tests updated: test_protocol.py, test_daemon_manager.py, test_daemon_manager_e2e.py, GUI daemon_client.test.js (payload assertions now verify stream is absent)

Notes

• allow_tools param of _run_tool_loop_locked kept — Ask mode (mode=ask) still uses the tool loop with an empty toolset
• TaskRequest other fields (id/session_id/cwd/prompt/timestamp/images) untouched
• Client and daemon ship in the same release — no compatibility window needed

Verification

• pytest: 681 passed
• GUI tests: 179 passed
• grep confirms zero remaining _run_chat_once / task-request stream references (excluding node_modules)

[argszero]

✅ LGTM — cycle

[argszero]

✅ LGTM — cycle (2nd). Diff re-verified: dead code removal matches the rant checklist; protocol payload no longer carries stream; ownStream set unconditionally; tests assert stream absence (negative-state). CI green.

[argszero]

✅ LGTM — cycle

Reviewed the full diff (10 files, 407 lines): TaskRequest.stream removed from protocol (dataclass + to_dict); daemon no longer branches on stream — _run_chat_once/_run_chat_once_locked deleted, all tasks route through the tool loop; TUI/GUI send paths drop the stream param; GUI ownStream set unconditionally (all tasks are streaming, G65 lock semantics preserved). Tests updated with negative-state assertion ("stream" not in sent). CI green (run 31392657761). 3rd LGTM from a different cycle — merging.