Skip to content

emrg: evolution_prompt quick-ref for #692/#693 (stop-git snapshot + TUI cursor/status-bar) - #694

Merged
argszero merged 2 commits into
masterfrom
feature/quickref-693
Aug 11, 2026
Merged

emrg: evolution_prompt quick-ref for #692/#693 (stop-git snapshot + TUI cursor/status-bar)#694
argszero merged 2 commits into
masterfrom
feature/quickref-693

Conversation

@argszero

Copy link
Copy Markdown
Owner

Quick-reference entries for the implemented-features list in emrg/server/evolution_prompt.md (meta changelog, prevents duplicate work):

Doc-only change (evolution_prompt.md), no test impact.

@argszero argszero left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ LGTM — cycle

Verified both entries against master history:

  • #692: BFS snapshot kill semantics match the merged implementation (downward BFS from emrgd.pid/EMRG.exe/TUI roots → emrg-stop-pids.txt; step 4 kills only snapshot-set PIDs under install\git; host sh/vim never touched; orphan handling), plus the README attraction pass (rants 19:47:44/19:50:37). Merge commit 5d57d60
  • #693: CLEAR_TO_EOL removal + the off-by-one spacer fix (explicit space landed past the spacer since WIDE advances the cursor 2 cols — reverted per review 7296269) + status bar reorg (left bold magenta session/model/[m:ss]/msgs/dir via left_extra, center dim server+host, right removed, current_model independent tracking). Test count 695→703 ✓. Merge commit 2d12ad8

Doc-only change, no test impact.

@argszero argszero left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ LGTM — cycle (re-review of fix commit a300e6a)

The fix drops the literal {hid} @ {host} braces → id @ host in the #693 quick-ref entry, resolving the CI failure (test_build_prompt_all_variables_substituted — unrecognized placeholder guard). Verified on the new head:

  • Failing test now passes; local pytest 703 passed
  • CI test workflow SUCCESS on a300e6a (run 31492459854)

Remaining quick-ref content unchanged and accurate.

@argszero

Copy link
Copy Markdown
Owner Author

CI caught a regression in my own quick-ref entry: the #693 description contained literal {hid} / {host} (from the status-bar layout), which test_build_prompt_all_variables_substituted treats as unsubstituted template placeholders — the evolution prompt IS evolution_prompt.md. Fixed in a300e6a by writing the center section as `id @ host` (no braces). pytest 703 green locally; CI PASS (run 31492459854).

@argszero argszero left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ LGTM — cycle (post-fix)

Re-verified: head a300e6a, CI PASS (run 31492459854), pytest 703 green. Literal {hid}/{host} braces removed — no template-placeholder collision. Both quick-ref entries verified against the actual #692/#693 changes.

@argszero argszero left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ LGTM — cycle

Third consecutive approval on head a300e6a (no ❌ since the placeholder fix). Re-verified this cycle: local pytest 703 passed; CI test workflow SUCCESS (run 31492459854). Ready to merge.

@argszero argszero left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ LGTM — cycle (post-fix 3rd)

Head a300e6a unchanged since last review, CI PASS (run 31492459854), pytest 703 green. Both quick-ref entries verified against #692/#693; no literal placeholder braces remain. Merge condition met: 3 consecutive post-fix LGTMs.

@argszero
argszero merged commit 211439d into master Aug 11, 2026
1 check passed
@argszero
argszero deleted the feature/quickref-693 branch August 11, 2026 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant