emrg: fix .iss LoadStringFromFile 2-param signature (v0.2.30 Build Release windows gate) - #732
Closed
argszero wants to merge 1 commit into
Closed
emrg: fix .iss LoadStringFromFile 2-param signature (v0.2.30 Build Release windows gate)#732argszero wants to merge 1 commit into
argszero wants to merge 1 commit into
Conversation
…lease windows gate) v0.2.30 Build Release 31661378619 failed at the windows 'Make installer' step: iscc rejected the emrg.iss [Code] section with 'Invalid number of parameters' on LoadStringFromFile(LogFile). Root cause: Inno Setup's Pascal Script API declares function LoadStringFromFile(const FileName: String; var S: AnsiString): Boolean; (2-param out-argument form, identical in 6.7.1 through 7.x — verified against issrc Shared.ScriptFunc.pas). #727's R125 log-surfacing code called the non-existent 1-param string-returning form; the Test workflow never compiles the .iss, so the error only surfaced at tag-push Build Release (v0.2.7 lesson recurring). Fix: - make-installer.sh: call LoadStringFromFile(LogFile, LogText) (out-param), keep FileExists guard + 2000-char truncation - tests/test_installer_stop.py: assert the 2-param form (positive) and forbid the 1-param form (negative) - test.yml test-windows: new 'Inno Setup script compile smoke test' step — renders the emrg.iss heredoc (stub payload) and runs the runner's preinstalled iscc, so .iss syntax/signature errors fail PR CI instead of at release time
Owner
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the v0.2.30 Build Release failure 31661378619 (windows-2025 'Make installer' step): iscc rejected the generated
emrg.isswithError on line 183 ... Invalid number of parameters.Root cause
Inno Setup's Pascal Script API declares
— a 2-parameter out-argument form, identical in iscc 6.7.1 through 7.x (verified against issrc
Shared.ScriptFunc.pasat tags is-6_7_1 / is-6_7_3 / is-7_1_0 / main). #727's R125 log-surfacing code (merged in eb38234) called the non-existent 1-parameter string-returning formLogText := LoadStringFromFile(LogFile). The Test workflow never compiles the .iss, so the error only surfaced at tag-push Build Release — the v0.2.7 lesson recurring.Changes
LoadStringFromFile(LogFile, LogText)(out-param), keep theFileExistsguard and 2000-char truncation; comment documents the real signatureVerification
$varexpansionsimport run_client+emrg --helpgreen