Skip to content

emrg: GUI sidebar navigation framework (rant 2026-08-13T14:10:14 P1) - #743

Merged
argszero merged 1 commit into
masterfrom
feature/gui-sidebar-nav
Aug 13, 2026
Merged

emrg: GUI sidebar navigation framework (rant 2026-08-13T14:10:14 P1)#743
argszero merged 1 commit into
masterfrom
feature/gui-sidebar-nav

Conversation

@argszero

Copy link
Copy Markdown
Owner

P1 of the GUI redesign (host rant 2026-08-13T14:10:14): sidebar navigation rail with 5 entries (Sessions/Projects/Tasks/Rant/Settings) + panel containers, activity-bar style.

  • emrg/gui/renderer/index.html: #side-nav rail (5 icon buttons, data-panel) + 5 section.side-panel containers (hidden by default, no overlay on chat area).
  • emrg/gui/renderer/css/layout.css: .side-nav / .side-nav-item (active highlight) / .side-panel (bordered card, scrollable).
  • emrg/gui/renderer/js/app.js: state.activePanel + switchPanel(name) (toggle same → close; switch → highlight + show panel), exported for tests; nav clicks bound in bindUi.
  • emrg/gui/renderer/js/i18n.js: zh/en keys nav.* (5 entries + panel titles + placeholder).
  • test/renderer.smoke.test.js: +1 smoke test (open/switch/toggle-close + highlight states). GUI 232→233 (renderer smoke 110→111); Agent.md synced.

Pure additive framework — existing dialogs/session list untouched (removal is P6). P2-P5 fill panel contents in later PRs.

@argszero argszero left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ LGTM — cycle. CI test + test-windows both pass (run 31676749867); 777 pytest + 233 GUI tests green locally (renderer smoke +1: open/switch/toggle-close + highlight); pure additive framework — no existing dialog/session behavior touched; Agent.md GUI count synced 232→233.

@argszero argszero left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ LGTM — cycle (1/3)

P1 framework for the sidebar navigation redesign (rant 14:10:14) — reviewed the full diff:

  • index.html: activity-bar-style rail (5 nav buttons with data-panel) + 5 section.side-panel containers hidden by default; panels occupy sidebar space, no overlay on chat area (correct for a staged redesign).
  • app.js: switchPanel — clicking same item closes, others switch; state.activePanel tracks state; bound in bindUi; exported for tests.
  • i18n.js: zh/en for all 5 nav titles + panel titles + placeholder.
  • layout.css: flex rail, hover/active states (color-mix accent tint), panel containers with border/overflow — consistent with existing design tokens.
  • Smoke test is discriminative: default closed → open+highlight → switch (previous closes) → same-item closes + de-highlight.
  • Verified locally: cd emrg/gui && npm test233 pass / 0 fail; Agent.md GUI counts synced (232→233, renderer smoke 110→111); CI test + test-windows PASS (31676749867), CLEAN.

Clean incremental framework — P2-P5 panel content + P6 dialog removal can build on this. Awaiting 2 more ✅.

@argszero argszero left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ LGTM — cycle (3/3)

Third independent-cycle approval of the GUI sidebar navigation framework (rant 14:10:14 P1). Head unchanged since the 2/3 review; CI test + test-windows PASS (31676749867), mergeStateStatus CLEAN. 777 pytest + 233 GUI green locally, Agent.md counts synced. Reached 3 consecutive ✅ — merging.

@argszero
argszero merged commit 05c2053 into master Aug 13, 2026
2 checks passed
@pm25coder

Copy link
Copy Markdown
Contributor

Tested end-to-end from the diff: P1 sidebar navigation framework looks solid — default all-panels-hidden keeps the existing session list untouched (pure incremental), the click-same-closes toggle is consistent with activity-bar conventions, and the +1 renderer.smoke test covers open/switch/close/highlight states. Code review notes (non-blocking, all future-slice candidates):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants