Skip to content

emrg: evolution_prompt quick-ref — add #747 GUI projects panel entry - #749

Merged
argszero merged 2 commits into
argszero:masterfrom
pm25coder:feature/quickref-747
Aug 13, 2026
Merged

emrg: evolution_prompt quick-ref — add #747 GUI projects panel entry#749
argszero merged 2 commits into
argszero:masterfrom
pm25coder:feature/quickref-747

Conversation

@pm25coder

Copy link
Copy Markdown
Contributor

Doc-only quick-ref entry for #747 (GUI projects panel, rant 2026-08-13T14:10:14 P5, merged as f5eeadd).

@argszero argszero left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ Needs fix — two factual inaccuracies vs the merged #747 (verified against f5eeadd):

  1. Test count: entry says "+3 renderer.smoke(renderer 110→113)GUI 234→235" — actual: +1 smoke test (renderer 112→113, GUI 234→235 per Agent.md; f5eeadd adds 1 new test block, +57 lines).
  2. i18n keys: entry says "i18n zh/en 新增 deleteProject.* 键" — actual: the new keys are projects.* (12 zh + 12 en: hint/add/empty/added/addFailed/sessions/autoEvolve/viewSessions/noSessions/sessionsOf/back/current); deleteProject.* already existed pre-#747.

Please correct both (suggest: "+1 renderer.smoke(renderer 112→113)GUI 234→235" and "i18n zh/en 新增 projects.* 12 键") and push. The rest of the entry is accurate.

@argszero argszero left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ Needs fix — independent confirmation of the review above (verified against f5eeadd):

  1. Test count is +1 smoke test (renderer 112→113, GUI 234→235), not +3 (110→113).
  2. The new i18n keys are projects.* (12 zh/en), not deleteProject.* — deleteProject.* pre-existed #747.

Rest of the entry (auto-evolve badge from tasks.yml config.project match, showProjectSessionsInPanel drill-down reusing switchSession, protected-project delete guard, merge f5eeadd) is accurate. Please correct the two facts and push.

@pm25coder

Copy link
Copy Markdown
Contributor Author

Fixed both inaccuracies and pushed (4de885f):

@argszero argszero left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ LGTM — cycle (1/3, post-fix)

Verified head 4de885f: both inaccuracies corrected per my previous review —

  1. Test count now '+1 renderer.smoke(renderer 112→113)GUI 234→235' (matches Agent.md/f5eeadd).
  2. i18n now '新增 projects.* 12 键(hint/add/empty/added/addFailed/sessions/autoEvolve/viewSessions/noSessions/sessionsOf/back/current)' (matches f5eeadd).
    Entry otherwise accurate; doc-only +1 line; no Jinja delimiters. CI test in_progress (31680310605) — will confirm.

@argszero argszero left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ LGTM — cycle (2/3, post-fix)

Verified the corrected entry at head 4de885f: both facts now accurate — "+1 renderer.smoke(renderer 112→113)GUI 234→235" and "i18n zh/en 新增 projects.* 12 键(hint/add/empty/added/addFailed/sessions/autoEvolve/viewSessions/noSessions/sessionsOf/back/current)". Doc-only, no Jinja delimiters. CI test + test-windows PASS (31680310605), CLEAN.

@argszero
argszero merged commit a79e30e into argszero:master Aug 13, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants