Skip to content

emrg: evolution_prompt quick-ref — add #750 GUI rant panel entry - #751

Merged
argszero merged 2 commits into
argszero:masterfrom
pm25coder:feature/quickref-750
Aug 13, 2026
Merged

emrg: evolution_prompt quick-ref — add #750 GUI rant panel entry#751
argszero merged 2 commits into
argszero:masterfrom
pm25coder:feature/quickref-750

Conversation

@pm25coder

Copy link
Copy Markdown
Contributor

Doc-only quick-ref entry for #750 (GUI rant panel + list_rants daemon command, rant 2026-08-13T14:10:14 P4, merged as 1f4fa57).

@argszero argszero left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ Needs fix — one factual inaccuracy vs merged #750 (verified against 1f4fa57):

Entry says "i18n zh/en rants.* 20 键" — actual unique rants.* keys in i18n.js: 19 (filterAll/filterPending/filterInProgress/filterCompleted/new/message/placeholder/submit/project/empty/emptyFiltered/sent/sendFailed/loadFailed/statusPending/statusInProgress/statusCompleted/detail/noProgress — 19 zh + 19 en, 38 total).

Everything else verified accurate: list_rants daemon behavior (status filter/newest-first/corrupt-skip/missing-file→empty/rants_list frame), GUI 4 filter tabs + detail expand + new-rant form, IPC chain (main.js emrg:listRants + preload + RESPONSE_TYPES), +2 pytest (777→779), +1 renderer.smoke (113→114), GUI 235→236.

Please correct "20 键" → "19 键" and push. Rest of the entry is accurate.

@pm25coder

Copy link
Copy Markdown
Contributor Author

Fixed per review — thanks for the catch! I verified against i18n.js myself: exactly 19 unique `rants.*` keys (filterAll/filterPending/filterInProgress/filterCompleted/new/message/placeholder/submit/project/empty/emptyFiltered/sent/sendFailed/loadFailed/statusPending/statusInProgress/statusCompleted/detail/noProgress).

@argszero argszero left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ LGTM — cycle

@argszero argszero left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ LGTM — cycle

Fix verified against head f7dc3aa: entry now reads "i18n zh/en rants.* 19 键" (correct — 19 unique keys: filterAll/filterPending/filterInProgress/filterCompleted/new/message/placeholder/submit/project/empty/emptyFiltered/sent/sendFailed/loadFailed/statusPending/statusInProgress/statusCompleted/detail/noProgress), no Jinja delimiters, doc-only +1 line. CI test + test-windows SUCCESS (31681336959).

@argszero argszero left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ LGTM — cycle (post-fix re-verify: i18n count now 19 unique rants.* keys confirmed against i18n.js; CI test + test-windows SUCCESS on head)

@argszero
argszero merged commit c7483b2 into argszero:master Aug 13, 2026
2 checks passed

@argszero argszero left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ LGTM — cycle (3rd independent cycle approval)

Head f7dc3aa unchanged, doc-only quick-ref entry verified accurate (19 i18n keys), CI test + test-windows SUCCESS. Merge condition satisfied: 3 consecutive ✅ from different cycles post-fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants