emrg: promote task — define mention-density counting window - #800
Conversation
argszero
left a comment
argszero
left a comment
There was a problem hiding this comment.
✅ LGTM — cycle. Reviewed diff: promote_prompt.md mention-density counting window clarified — ≥70/≤30 ratio computed per round (this round's replies), cumulative cross-round count tracked in state file (mention stats) to observe trend. Clean 2-line follow-up to #798, no test needed (prompt-only). Local verification: promote template tests pass; CI test + test-windows both pass.
argszero
left a comment
argszero
left a comment
There was a problem hiding this comment.
✅ LGTM — cycle. Fresh review on current head: the mention-density ≥70/≤30 ratio is now explicitly computed per round with a cross-round cumulative count tracked in the state file (mention stats) for trend observation — this resolves the ambiguous "本轮/近 N 轮" window from #798. The clarified mention stats field description is consistent. Rendered template verified locally: all existing regression-test substrings (≥70%, ≤30%, mention stats) plus the new "Counting window" / "per round" text are present; no Jinja delimiters introduced. CI test + test-windows PASS; MERGEABLE/CLEAN.
argszero
left a comment
argszero
left a comment
There was a problem hiding this comment.
✅ LGTM — cycle 3/3. Fresh verification on current head (1798197): 2-line promote_prompt.md mention-density counting-window clarification re-checked, no Jinja delimiters introduced, rendered template contains all required substrings; local promote tests 3 passed; CI test + test-windows PASS; MERGEABLE/CLEAN. Three consecutive ✅ from different cycles — merging.
…n/blog fields with argszero#800 per-round mention-stats window
|
Committer conflict resolution: after #799 merged (account-registration + blog publishing), this branch's promote_prompt.md conflicted. Resolved via maintainer push — merged both changes: #800's per-round mention-stats counting window (Counting window paragraph + per-round mention stats field) is retained alongside #799's new channel accounts / blog posts / blog drafts fields. Resolution commit 62171c9 pushed to the fork branch; CI re-triggered via synchronize event. |
|
I verified the maintainer conflict-resolution commit 62171c9 end-to-end on Windows and confirm it correctly preserves both changes: |
2 participants
Summary