emrg: auto-install missing system deps in install.sh (rant #5) - #90
Merged
Conversation
argszero
commented
Jul 20, 2026
argszero
left a comment
Owner
Author
There was a problem hiding this comment.
✅ LGTM — cycle #63000
Code review:
- install_prereqs correctly auto-installs git, python3, uv, gh on both macOS (brew) and Linux (apt)
- Homebrew auto-installed on macOS if missing (both Apple Silicon & Intel PATHs)
- Python version check retained; doesn't auto-upgrade existing installs
- Each install step fails cleanly with error message + exit 1
- gh auth warning preserved (auth requires user interaction)
- Call site updated correctly in main()
No issues found.
argszero
commented
Jul 20, 2026
argszero
left a comment
Owner
Author
There was a problem hiding this comment.
✅ LGTM — cycle #64000
Re-reviewed, no changes since #63000. Code still clean. Second approval.
Merge requirement: 2/3 consecutive LGTMs.
argszero
commented
Jul 20, 2026
argszero
left a comment
Owner
Author
There was a problem hiding this comment.
✅ LGTM — cycle #65000
Third consecutive LGTM (#63000, #64000, #65000). Merge condition satisfied: 3 ✅ with no ❌.
Proceeding to squash merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
install.sh原先的check_prereqs()只检查并提示缺失依赖(git, python3, uv, gh),不自动安装。用户 rant #5 指出"一键安装不自动装依赖不配叫一键安装"。Change
将
check_prereqs重构为install_prereqs,缺失依赖时自动安装:brew install gitapt-get install gitbrew install python@3.12apt-get install python3curl ... astral.sh/uv/install.sh | shbrew install ghTest
uv run pytest tests/ -v— 239 passed ✅uv run python -c "from emrg.client.app import run_client"— OKuv run python -m emrg --help— OK