Upgrade to go-subcommand v0.0.17 - #5
Conversation
- Update go.mod to use github.com/arran4/go-subcommand v0.0.17 - Add tools.go to track go-subcommand dependency - Regenerate CLI code using go-subcommand v0.0.17 - Add UPGRADE_REPORT.md detailing bugs and issues found Note: The generated code in cmd/mdsplit/root.go is currently broken due to a bug in go-subcommand v0.0.17 (missing package qualification). See UPGRADE_REPORT.md for details. Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
- Added `cmd/mdsplit/fix_root.go` to patch `cmd/mdsplit/root.go`. - Updated `cmd/mdsplit/main.go` to run `fix_root.go` after `gosubc generate`. - Manually applied the patch to `cmd/mdsplit/root.go` so it compiles. - Updated `UPGRADE_REPORT.md` (no changes needed, just acknowledging the fix). Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
1 participant
Upgrade to
github.com/arran4/go-subcommandv0.0.17.This PR includes the updated
go.mod, generated CLI code, and a report of issues found during the upgrade.Status: The upgrade is blocked by a bug in
gosubcv0.0.17 which generates invalid Go code (missing package qualification forRunfunction). The generated code fails to compile.Issues Found:
cmd/mdsplit/root.gocallsRun(...)instead ofmdsplit.Run(...).go generatecontext: Runninggo generatefrom root fails to findgo.modbecausegosubcexpects it in the working directory.cmd/errors.goandcmd/mdsplit/root_test.gowere created.See
UPGRADE_REPORT.mdfor more details.PR created automatically by Jules for task 1179429252776625809 started by @arran4