Improve CMake files#167
Merged
Merged
Conversation
9prady9
requested changes
Apr 5, 2018
| # CMake files | ||
| if(NOT DEFINED FG_INSTALL_CMAKE_DIR) | ||
| set(FG_INSTALL_CMAKE_DIR "cmake" CACHE PATH "Installation path for CMake files") | ||
| set(FG_INSTALL_CMAKE_DIR "lib/cmake/Forge" CACHE PATH "Installation path for CMake files") |
Member
There was a problem hiding this comment.
Just cmake works for Windows OS. I was testing this on Windows initially, thus forgot set it for *nix platforms. Can you please add a check for WIN32 and set it to cmake and leave lib/cmake/Forge for the rest.
9prady9
approved these changes
Apr 5, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves some parts of CMake files.
ConfigandTargetfiles to the location where CMake actually looks for them.FindForgeconsistent with the documentation (i.e.,Forge, notFORGE).