Cmake fixes#195
Merged
Merged
Conversation
9prady9
commented
Jan 27, 2019
9prady9
commented
Member
- Fix cmake target exports - build tree and install targets were mixed up earlier.
- Avoid installing dependency dlls when building static library
umar456
reviewed
Jan 30, 2019
Member
Author
|
@umar456 I don't think so, the destination directory didn't change. I fixed the mix up of config files generated for install-interface and build tree. Config files related to build tree are still generated and are available using Config files for installation is same as before nothing changed in that aspect. |
umar456
reviewed
Jan 30, 2019
Member
Author
|
Addressed feedback. |
umar456
approved these changes
Feb 11, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.