Repository navigation
fix(cluster): refuse unplanned models in checks and serve - #2069
Merged
Merged
Conversation
Owner
|
Thanks @swbiggart. Printing "not planned" and exiting 0 was a real trap for scripts, and the fix puts it on the same footing as a model that doesn't fit, with a test for each command and both refusal kinds. One small thing: could you add a CHANGELOG line saying |
swbiggart
added a commit
to swbiggart/TensorFold-upstream
that referenced
this pull request
Nov 3, 2026
swbiggart
force-pushed
the
review-ready/cluster-exit
branch
from
November 3, 2026 23:24
aa13720 to
a25ffe1
Compare
swbiggart
added a commit
to swbiggart/TensorFold-upstream
that referenced
this pull request
Nov 3, 2026
Owner
|
Thanks @swbiggart. The CHANGELOG line is exactly what we asked for, and the code commit is the one we reviewed, so this is ready to land. |
ashhart
force-pushed
the
review-ready/cluster-exit
branch
from
November 4, 2026 10:03
a25ffe1 to
27748f8
Compare
ashhart
pushed a commit
to swbiggart/TensorFold-upstream
that referenced
this pull request
Nov 4, 2026
Return 1 when planning fails, including the preflight used by serve. Dry-run serve now refuses before describing a launch. Keep the existing all-model check and its --model filter.
ashhart
force-pushed
the
review-ready/cluster-exit
branch
from
November 4, 2026 11:37
27748f8 to
41dcd4f
Compare
Owner
|
Thank you @swbiggart. This is merged into main with your commits under your own name, so you're listed as a TensorFold contributor. It ships in the next release, credited to you in the changelog and the release notes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
cluster checkandcluster statusprintednot plannedbut returned success when a model could not be planned. Return 1 for that failure.serve, including--dry-run, now stops at this preflight before describing or attempting a launch.The existing preflight checks every configured model unless
--modelfilters it:serve Acan therefore now refuse because a different model B cannot be planned. A non-fitting B already blocked A; this change leaves model selection unchanged.023def309dd1d5534c740fb7465e2835cee3ee2cto resolve the changelog conflict. Current head:a25ffe1cdb691b633e5a0f973b846f06551ea1a3.atc overlap --json: incomplete (pullFilesLimit,pullFilesUnavailable,timeLimit). A separate paginated audit of all 173 open PRs on 2026-11-03 at 19:55 UTC found no PR changing these files; related cluster discussions and merged changes were also checked.Checks
e8089a852c95043fe679f7db9601500c88746486, before the rebase and changelog-only follow-up. Both changed Zig files are byte-identical to that tested commit.git diff --checkpasses; the rebased branch merges cleanly with main. No tests rerun for the documentation-only follow-up.python3 tools/zig/lean_check.py: 424 problems on base and head, 0 new.serve --dry-runfails the expected-exit-1 assertion with actual 0; the filtered run has 7 passes and 1 failure before the fix and 8 passes afterward (7 module test blocks and 1 behavior regression; 0 skipped). It also checkscheckandstatusfor missing file lists and unsupported estimates.zig build test test-kernel-contract test-golden test-server-security test-pull-security fuzz-cortheon -Dcpu=apple_m1 -j1 --summary all: exit 0; 675/675 steps succeeded, 372/378 tests passed, 6 skipped. This final-head run was mostly cached.zig build -Dcpu=apple_m1 -j1 --summary all: exit 0; 250/250 steps succeeded.zig fmt --checkon both changed files andgit diff --check: pass.Filtered regression command:
Receipt
n/a: host planner exit codes only; no inference path changes. Checks ran on Apple M5 Max, macOS 27.2, Zig 0.17.0.
Checklist