Repository navigation
fix(preview): parse tight list items with pulldown-cmark 0.13.4 - #20
Merged
Merged
Conversation
The preview builder walks this input while it turns a note into HTML. Co-authored-by: Andrejs Strazds <astrazds@users.noreply.github.com>
Version 0.13.3 unwraps an empty tight paragraph and aborts preview. Co-authored-by: Andrejs Strazds <astrazds@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Preview turns a note into HTML with pulldown-cmark 0.13.3. That parser panics on a short list item, so Linux preview aborts and the Windows session faults.
What changed
render_markdown_preview_bodynow covers the list item- [n]:Zfollowed by a blank tab line.pulldown-cmarkmoves from 0.13.3 to 0.13.4.Scope
Covers the preview parser panic. Leaves other dependency updates alone.
Blast Radius
Ordinary notes still go through the same renderer. The patch only changes how an empty tight paragraph is skipped.
Verification
cargo test -p nota-core --locked --lib renders_a_link_reference_shaped_list_itempanicked atpulldown-cmark-0.13.3/src/parse.rs:2367before the bump, then passed.cargo test -p nota-core --lockedpassed. 99 library tests plus the backup and transition suites.cargo test -p nota-app --locked --libpassed. 40 tests.cargo test -p nota-app --locked --test session_workflowspassed. 12 tests.