Repository navigation
docs(appimage): match the second import check to the dialog - #23
Merged
Merged
Conversation
A second complete file offers Import these notes? instead of a rejection. Co-authored-by: Andrejs Strazds <astrazds@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The rehearsal summary says a second restore is rejected. The same procedure's import step, and the import menu, offer Import these notes? for a complete file opened into a notebook that already has notes.
What changed
Scope
Covers the summary line. The numbered steps already described that dialog.
Blast Radius
Someone rehearsing the AppImage follows the menu path instead of expecting a rejection from a direct restore call.
Verification
cargo test -p nota-core --locked --lib complete_file_into_a_nonempty_notebook_merges_active_notes_onlypassed. A complete file staged into a nonempty notebook stays on the merge arm, whose confirmation title is "Import these notes?".