Repository navigation
docs(adr): record the Backup export kind - #24
Merged
Merged
Conversation
Backup / Export writes a desktop transition, not a flat collection. Co-authored-by: Andrejs Strazds <astrazds@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The active identifier record says a new Backup export uses kind
nota.flat_collection. Backup / Export writes kindnota.desktop_transition.What changed
nota-backup-YYYY-MM-DD.json.Scope
Covers the export kind. Leaves the older restore-rejection bullet in the native-replacement record, which describes the cutover workspace.
Blast Radius
Readers of the active identifier record see the file kind the export command writes. Import of older flat files is unchanged.
Verification
cargo test -p nota-core --locked --lib export_mints_a_complete_notebook_and_embeds_that_clockpassed. The test expects kindnota.desktop_transition.backup_file_namestill returnsnota-backup-YYYY-MM-DD.json, and the session snapshot exposes that string assuggested_export_name.