Repository navigation
iio: aop_als: report colour temperature as IIO_COLORTEMP - #779
Open
RyanTheTide wants to merge 1 commit into
Open
RyanTheTide wants to merge 1 commit into
RyanTheTide wants to merge 1 commit into
Conversation
The Redbird colour temperature was exported as an IIO_CCT channel, in_cct_input. No other driver uses that type and the IIO ABI does not document it, so userspace looking for an ambient colour temperature (for example an ambient white point policy) reads in_colortemp_*, the documented channel that hid-sensor-als also provides. Report the same firmware-computed Kelvin value as a processed IIO_COLORTEMP channel, in_colortemp_input. Lux, the report decoding and the CT720 and CT817 parts are unchanged. Update the driver ABI note, the driver documentation and the J616s parity collector to the new name. Assisted-by: LLM Signed-off-by: Ryan Murray <ryan@aurorasilicon.org>
This was referenced Nov 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The AOP ambient light sensor on Redbird (VD6286) machines reports a firmware-computed colour temperature, and the driver exported it as an IIO_CCT channel,
in_cct_input. That type has no entry in the IIO ABI documentation and no other driver uses it. Userspace that wants an ambient colour temperature reads the documentedin_colortemp_*attributes, which hid-sensor-als also provides, so it never found this sensor.This reports the same Kelvin value as a processed IIO_COLORTEMP channel,
in_colortemp_input. Lux, the report decoding and the CT720 and CT817 parts are unchanged. The driver ABI note, the driver documentation and the J616s parity collector move to the new name.Consumers updated alongside: the opt-in GNOME ambient white point and iio-sensor-proxy patches read
in_colortemp_inputonly, and aurora-diag reads the new attribute.Testing
in_cct_input4171 K andin_illuminance_input100.7 lux. After,in_colortemp_input4168 to 4179 K,in_illuminance_inputabout 102 lux, noin_cct_input. iio-sensor-proxy with the ColorTemperature patch followed the new attribute for 10 minutes.tools/asahi/aop-als-channel-tests.pypasses, and all its mutations are caught.🤖 Generated with Claude Code