Conversation
Collaborator
|
for future claude fixes, can we link them under development of a PR? Then when we merge the PR, the issue should auto-close i did it for this one |
Collaborator
|
haven't looked into it but this test is failing |
…e round This commit limits block verification at any round to a single block at a time when receiving the block as a block message. This is to prevent from a malicious leader from sending many distinct blocks and overwhelming the node. Signed-off-by: Yacov Manevich <yacov.manevich@avalabs.org>
Collaborator
Author
Fixed the tests |
samliok
reviewed
Sep 3, 2026
| // Create a task that will verify the block in the future, after its predecessors have also been verified. | ||
| blockVerificationTask := e.createBlockVerificationTask(e.oneTimeVerifier.Wrap(block), from, vote) | ||
| // Mark the round as pending and wrap the task with a task that will cleanup the pending round after the block verification task is executed. | ||
| task := e.markPendingRoundAndCleanupAfter(md.Round, blockVerificationTask) |
Collaborator
There was a problem hiding this comment.
shouldnt we do this after the check below? otherwise if we receive an invalid block we will mark it as pending forever
samliok
reviewed
Sep 3, 2026
Signed-off-by: Yacov Manevich <yacov.manevich@avalabs.org>
samliok
approved these changes
Sep 3, 2026
Collaborator
|
hmm weird failure on |
yacovm
force-pushed
the
541
branch
2 times, most recently
from
September 3, 2026 22:40
83bc3a9 to
62de7c4
Compare
samliok
previously approved these changes
Sep 3, 2026
| } | ||
|
|
||
| // Create a task that will verify the block in the future, after its predecessors have also been verified. | ||
| task := e.createBlockVerificationTask(e.oneTimeVerifier.Wrap(block), from, vote) |
Collaborator
There was a problem hiding this comment.
where do we set this block as being processing? if the leader just sends via the handleBlockMessage() then don't we still run into this issue?
Collaborator
Author
Collaborator
Author
There was a problem hiding this comment.
// mark in future messages while we are verifying the block
msgForRound, exists := e.futureMessages[string(from)][md.Round]
if !exists {
msgsForRound := &messagesForRound{}
msgsForRound.proposalBeingProcessed = true
e.futureMessages[string(from)][md.Round] = msgsForRound
} else {
msgForRound.proposalBeingProcessed = true
}
Signed-off-by: Yacov Manevich <yacov.manevich@avalabs.org>
samliok
approved these changes
Sep 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit limits block verification at any round to a single block at a time when receiving the block as a block message.
This is to prevent from a malicious leader from sending many distinct blocks and overwhelming the node.