Repository navigation
Conversation
konductor install's summary folded an installed SOP's sop-<name>/SKILL.md conversion into the skills count, then separately claimed every staged SOP was skipped, even though SopInstallPhase installs every one of them (as a raw .konductor/sops/ copy and/or a Kiro-discoverable skill conversion) for all three harnesses. InstallCounts now derives a distinct sops count from the manifest, deduped by SOP name so a SOP's raw copy and its skill conversion count once. The --json sops_skipped key stays present (0 in the normal case) and now reports an actual shortfall between staged and installed SOPs instead of always equalling the staged count. No existing JSON key was removed or renamed.
simonkrol
force-pushed
the
dev/simonkrol/install_summary_counts
branch
from
October 5, 2026 22:03
56d3b06 to
b18b839
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
CLI:
konductor install's summary now reports SOPs and skills as separate counts for every harness (kiro-cli-v2,kiro-v3,claude) and both install paths (--fromand release fetch). Before this change, SOP conversions (sop-<name>/SKILL.md) were counted as skills, and every staged SOP was also reported as skipped even though it was installed.InstallCountsgains asopscount, deduped by SOP name across a SOP's raw.sop.mdcopy and its skill conversion. An entry counts as a SOP only when its name was staged as a SOP for this install, so a skill that happens to be namedsop-...(skills/sop-state-management/) stays a skill.--json: addssops. No existing key is removed or renamed.sops_skippedstays, is 0 when nothing was skipped, and reports staged minus installed SOPs.RemoteInstallOutcomebefore its scratch directory is deleted.Docs:
cli/README.md: removed the stale "SOPs are not installed anywhere" limitation and documented the SOP install destinations.install/kiro_cli.rs: fixed a module doc comment that said SOPs have no Kiro CLI destination.CHANGELOG.md:[Unreleased]/Fixedentry.Fixes # N/A
Type of Change
cli/) change, RustTesting
cargo build --release,cargo test --release(1733 passed, 0 failed),cargo clippy --release --all-targets(no new warnings in touched files)install --from . --harness kiro-cli-v2and--harness claudeinto fresh targets, human and--json. Both report 82 skills / 19 SOPs, matching on-disk contents.Checklist
Agents Affected
None. CLI
installsummary only.Notes for Reviewers
install.rs; there is nosops_converted_to_skillsfield onmainto reconcile with.check-guide-facts.pyhas a pre-existingconfigcheck failure onmain, unrelated to this change.--frompath is covered by unit tests through the fake remote installer. A live release-fetch run was blocked by GitHub's unauthenticated API rate limit in the test environment.