Repository navigation
Fix stale AWS MCP tool references in agents and skills - #38
Merged
Merged
Conversation
The AWS MCP server has removed aws___call_aws, aws___recommend, and aws___suggest_aws_commands, replacing the first and third with aws___run_script for running AWS CLI commands. k-architect, k-developer, and find-aws-skills still referenced the removed tools. aws___get_regional_availability now requires resource_type and filters parameters; aws-service-validator called it with only a service and region, which fails with a missing-required-field error. Confirmed live against the AWS MCP server (aws-mcp.us-east-1.api.aws/mcp) and verified aws___run_script is the documented replacement in the server's own tool catalog.
VERSION went to 1.0.4 in the previous commit but cli/konductor-rs's Cargo.toml stayed at 1.0.3. The release tarball's version segment comes from Cargo.toml (CARGO_PKG_VERSION), so this would have failed release.yml's version-match check after merge, as validate-pr.yml's own PR-time check caught. Cargo.lock regenerated via 'cargo update -p konductor --precise 1.0.4' to keep the two in sync.
knihit
marked this pull request as ready for review
October 6, 2026 03:15
knihit
requested review from
georgebearden,
ihmaws,
shsenior and
simonkrol
as code owners
October 6, 2026 03:15
ihmaws
requested changes
Oct 22, 2026
Resolve conflicts with main: keep main's VERSION and Cargo files, since the release bump belongs to its own PR, and re-apply the two systemPrompt edits on main's current prompts. Move the entries to [Unreleased], and describe aws___run_script as sandboxed Python with AWS API access.
…server defines them Only resource_type is required. filters is required for a multi-region call, regions takes up to 10 codes, and filter values must exactly match AWS's catalog names.
ihmaws
previously approved these changes
Oct 22, 2026
simonkrol
previously approved these changes
Oct 23, 2026
… fallback aws-service-validator now tells the agent to follow next_token when it lists catalog names with an unfiltered single-region call, so a partial first page isn't read as "name not found". find-aws-skills' confirmation rule now names the fallback it actually offers, direct AWS API calls via aws___run_script, instead of CLI tools.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Agents:
k-architect:aws___call_awsis removed from the AWS MCP server — updated the AWS MCP guidance to point ataws___run_script, the server's documented replacementk-developer: sameaws___call_aws→aws___run_scriptupdateSkills:
find-aws-skills: failure-handling fallback referencedaws___suggest_aws_commands, which the server no longer exposes. It now offers direct AWS API calls viaaws___run_script(sandboxed Python)aws-service-validator:aws___get_regional_availabilitynow requiresresource_typeandfiltersin addition toregions— the skill called it with only a service and region, which fails with a missing-required-field error; updated the call shape and the pitfall noteType of Change
Testing
npm testpasses (runstests/scripts/**/*.test.js) — 15 pre-existing failures (all tracing to a missingscripts/brand-config/lib/constants.js) reproduce identically on unmodifiedorigin/main; no new failures from this changecli/changed: not applicable, nocli/files touchedaws-mcp.us-east-1.api.aws/mcp)Checklist
[Unreleased]entry; the version bump is left to the release PR)make buildsucceeds); nocli/changes, socargo clippy/cargo fmtnot applicableAgents Affected
Notes for Reviewers
Found while reviewing whether konductor's AWS skills duplicate the AWS Agent Toolkit (
aws/agent-toolkit-for-aws). Three stale references turned up:aws___call_awsandaws___suggest_aws_commandsreturn"has been removed, use another one"when called against the live server.aws___get_regional_availabilityrejects a call with onlyregions, requiringresource_typeandfiltersas well.Confirmed directly against the live server's
tools/listandtools/callresponses, not from documentation alone.