Repository navigation
fix(guide): stop sync-html-content duplicating the Rust prerequisite row - #49
Merged
Merged
Conversation
ihmaws
marked this pull request as ready for review
October 14, 2026 15:16
ihmaws
requested review from
georgebearden,
knihit,
shsenior and
simonkrol
as code owners
October 14, 2026 15:16
A substitution rewrote the text that the Rust-row append inserts, so the append's already-applied check never matched and every --apply added another row (5 on main). The append now inserts the final text and the substitution is gone; the committed bundles are cleaned to one row. --apply now refuses to write a result that a second pass would change, naming the edits still firing. Fixes #48
ihmaws
force-pushed
the
dev/ihmaws/guide-rust-row-idempotency
branch
from
October 16, 2026 11:58
5440011 to
ff44ad4
Compare
simonkrol
approved these changes
Oct 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Docs tooling (
tools/build-user-guide/):html_sop_edits.py: the "essentials gains a Rust row" append now inserts the final "Built from a clone of the repository…" text. This makes it the only edit that owns the row.sync-html-content.py: removed the "qs prereq row: release framing" substitution. It rewrote the text the append had just inserted, so the append's already-applied check never matched and every--applyadded another row.sync-html-content.py:--applynow refuses to write a result that a second pass would change, and names the edits still firing. This catches any pair of edits that undo each other, not just this one.sync-html-content.py,html_sop_edits.py: renamedclaude-sonnet-5toclaude-sonnet-5.5in the edit tables. chore(agents): move every agent to claude-sonnet-5.5 #50 moved the HTML to the new model but not these edits, so 17 targets stopped matching andmake guide-htmlrefused to write.Docs:
docs/index.htmlanddocs/site/user-guide.html: two sentences chore(agents): move every agent to claude-sonnet-5.5 #50 missed ("Every agent runs claude-sonnet-5…") now sayclaude-sonnet-5.5, matchingagents.mdandreference.md. Also removed the 4 extra "A Rust toolchain" rows (5 → 1). The decoded page diff againstmainonly removes lines.Fixes #48
Type of Change
tools/build-user-guide/)Testing
sync-html-content.py --applyrun 3 times in a row: the first run inserted the single row, and the next two report "no change" for both bundles, which stay byte-identical.main's bundle with the old edit table, refuses to write and namesqs prereq row: release framing.sync-html-content.py --applyruns clean on both bundles, and a second run reports "no change".claude-sonnet-5(without.5) is left in either bundle, and they stay byte-identical.docs/index.htmllocally: Prerequisites → The essentials shows one "A Rust toolchain" row above "A terminal".Checklist
Notes for Reviewers
origin/mainand are left out of scope:build-user-guide.sh --checkfails because feat: publish Konductor as a Claude Code plugin marketplace #28 changeddocs/user-guide/**/*.mdwithout regenerating the HTML. This PR leaves the manifest unchanged.make guide-checkreports one failure: "configis listed as withdrawn… but cli/README.md no longer declares it".