[knihit]

Description

PR CI ran only the Kiro Power tests. The rest of tests/*.py, all of tests/skills/**/*.sh and the Rust tests for cli, mcp and shared never ran before merge. That's how a broken mcp telemetry test shipped in 1.0.3 and 1.1.0. This PR runs those suites and fixes the two tests that would otherwise block every PR.

CI (Makefile, .github/workflows/validate-pr.yml)

• Added make test-py, which runs python3 -m pytest -q tests/. CI runs it after make synth, so the tests that need build/cli/konductor run instead of skipping. The pip step now also installs pyyaml, which two tests import.
• Added make test-skills-sh, which runs every tests/skills/*/*.sh by glob, so new tests are picked up. SKILLS_SH_EXCLUDE lists tests known to fail, each with a reason.
• CI runs the Rust tests: cargo test in cli/konductor-rs, then make -C mcp test-rust and make -C shared test-rust. It reuses the existing toolchain step.

Fix: mcp mcp_tool_call events missed parentAgentName

• docs/telemetry-schema.json requires parentAgentName on every event. The skill-lookup MCP server's mcp_tool_call body left it out, so 1.0.3 and 1.1.0 sent events without it.
• It's now sent as an explicit null. This fixes mcp_tool_call_body_satisfies_schemas_required_list.

Fix: konductor update --cli could fail with "Text file busy"

• The self-update smoke test runs the binary it just wrote. A fork elsewhere in the process can briefly hold a write handle on it, so exec fails with ETXTBSY (os error 26).
• cli_self_update.rs now retries that exec up to 10 times, 100 ms apart. Unit tests drive the retry with a fake exec.
• real_smoke_test_succeeds_and_returns_stdout therefore runs in CI instead of being skipped.

Still excluded, each failing on main today

• tests/skills/persistent-memory/test-nonbullet-injection.sh: 2 of 8 cases fail. The test writes its URL allowlist to a different directory from the one memory-validator.sh reads (.konductor/), so the allowlist is never applied.
• cli::update::tests::update_finalize_index_reflects_a_concurrently_installed_other_strategy: skipped. On 4 CPUs it failed 5 of 10 full-suite runs. update_one_target sometimes returns 64.
• npm test: not added. 17 tests fail because scripts/brand-config/lib/constants.js isn't in the repo.
• make guide-check: not added. It fails on a stale config entry in WITHDRAWN_COMMANDS.

CHANGELOG.md has [Unreleased] / Fixed entries for both fixes.

Supersedes #47 and #61, both closed.

Type of Change

• CLI (cli/) change: Rust
• Infrastructure / pipeline

Testing

• This PR's own CI: every Status Checks step passes, including the new pytest, skill shell and Rust steps.
• make -C mcp test-rust: all pass. The schema test fails without the fix.
• ETXTBSY retry, on 4 CPUs (taskset -c 0-3):
  • 19 cli_self_update tests pass.
  • The smoke test passed 20 of 20 runs on its own.
  • The full cli suite passed 5 of 5 runs, 1734 unit tests each, with only the update_finalize_index... skip.
• make test-py and make test-skills-sh pass on main with the exclusions above. With SKILLS_SH_EXCLUDE= emptied, the target fails and names the file.
• The workflow parses (PyYAML).
• npm test: fails on main, see above
• cd cli && make test: covered by the cli cargo test runs above
• Changed code files carry the SPDX header

Checklist

• My code follows the style guidelines of this project
• I have performed a self-review of my own changes
• I have commented my code where necessary
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added or updated tests that prove my change works

Notes for Reviewers

• Merge order: merge this first, so the new tests in fix(plugin): clean candidate tree, skill script paths and k-architect delegation #57 and feat: add a telemetry hook to the Claude Code plugin #60 gate their merges.
• Follow-ups, each removing an exclusion:
  • Point test-nonbullet-injection.sh at .konductor/memory-config.json.
  • Fix the update_finalize_index... race.
  • Restore or replace scripts/brand-config/lib/constants.js for npm test.
  • Remove the stale config entry for make guide-check.
• CI time: the Rust step adds a debug build of cli, mcp and shared. A cargo cache would offset it, but that's left for a separate change.