Repository navigation
Allow inline type hints to be packaged and distributed (PEP561) #223
Description
Activity
Hi @jamesdow21 , my apologies for the delay in response for this issue and your PR. Also, thank you for taking the time to open a PR for this issue.
Not sure if this issue is fixed. I have the latest version of redshift-connector
redshift-connector==2.1.3And inside my site-packages I don't see the
py.typedfile
And I also still get the error from mypy:
redshift.py:1:1: error: Skipping analyzing "redshift_connector": module is installed, but missing library stubs or py.typed marker [import-untyped] redshift.py:1:1: note: See https://mypy.readthedocs.io/en/stable/running_mypy.html#missing-imports
Can also confirm that the latest published version does not include the added py.typed file
I can't replicate the behavior whenever I build locally though.
Looking at the wheel published to PyPI, it shows that in the WHEEL metadata file
Generator: bdist_wheel (0.33.6)I installed that same version of wheel and a version of setuptools that was published around the same time (setuptools==41.2.0) and tried building it locally again, but my local build still includes the py.typed file
@Brooke-white Do you have any insight on what might be different between the local build script and the actual build and publish steps that upload the wheel to PyPI?
Driver version
Redshift version
Client Operating System
Python version
Table schema
Problem description
It looks like this package has type annotations fully specified inline, but mypy doesn't recognize that the type hints can be used without a "py.typed" marker file (as described in PEP561).
error: Skipping analyzing "redshift_connector": module is installed, but missing library stubs or py.typed marker [import-untyped]Python Driver trace logs
Reproduction code