Skip to content

Add documentation for maximum expiration time for an S3 presigned URL… - #6348

Merged
kyleknap merged 1 commit into
aws:v2from
kdaily:v2-add-max-expiration-presigned
Aug 26, 2021
Merged

kyleknap merged 1 commit into
aws:v2from
kdaily:v2-add-max-expiration-presigned

Conversation

@kdaily

@kdaily kdaily commented Aug 19, 2021

Copy link
Copy Markdown
Member

Issue #, if available:

Fixes #5464

Description of changes:

Add documentation for the max expiration time of an S3 presigned URL when using SigV4.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov-commenter

codecov-commenter commented Aug 19, 2021 •

Copy link
Copy Markdown

Codecov Report

Merging #6348 (c66c5f9) into v2 (aeb792f) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##               v2    #6348   +/-   ##
=======================================
  Coverage   94.20%   94.20%           
=======================================
  Files         273      273           
  Lines       21780    21780           
=======================================
  Hits        20518    20518           
  Misses       1262     1262           
Impacted Files Coverage Δ
awscli/customizations/s3/subcommands.py 97.23% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aeb792f...c66c5f9. Read the comment docs.

@kdaily
kdaily requested a review from kyleknap August 23, 2021 22:14

@kyleknap kyleknap left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@kyleknap
kyleknap merged commit cee4d89 into aws:v2 Aug 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

S3 presign cli allow url generated more than 7 days (--expires-in greater than 604800)

3 participants