fix a bug where destroying a creds provider during a operation can lead to a use after free - #3884
Merged
Merged
Conversation
sbiscigl
marked this pull request as ready for review
July 30, 2026 20:48
sbiscigl
force-pushed
the
crt-creds-use-after-free
branch
from
July 30, 2026 20:54
f839fb1 to
864e97c
Compare
kai-ion
approved these changes
Jul 30, 2026
sbiscigl
force-pushed
the
crt-creds-use-after-free
branch
from
July 30, 2026 21:30
864e97c to
0a7a8b1
Compare
…ad to a use after free
sbiscigl
force-pushed
the
crt-creds-use-after-free
branch
from
July 31, 2026 14:06
0a7a8b1 to
d5b12a9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
If a crt credentials provider is destroyed during its operation, the async callback may return after the stack variable has fell off. this moves the lock to a heap variable thats lifetime is managed by a shared pointer to avoid lifetime issues.
Check all that applies:
Check which platforms you have built SDK on to verify the correctness of this PR.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.