Switch to AuthGenerator in tunnel pool - #7252
Merged
dagnir merged 2 commits intoAug 11, 2026
Merged
Conversation
Use the new AuthGenerator mechanism in the `Http1TunnelConnectionPool` and `AwaitCloseChannelPoolMap` classes. For now, supports only using BASIC auth; Kerberos will be added in a subsequent PR.
dagnir
force-pushed
the
dongie/netty-tunnel-handler-auth-generator
branch
from
August 10, 2026 22:23
6f3e9f9 to
0e63c9e
Compare
Original impl allowed empty (e.g. whitespace) in username and pass for BASIC auth so preserve that behavior.
dagnir
force-pushed
the
dongie/netty-tunnel-handler-auth-generator
branch
from
August 10, 2026 22:24
0e63c9e to
bf43046
Compare
joviegas
approved these changes
Aug 11, 2026
dagnir
merged commit Aug 11, 2026
b2aaf34
into
feature/master/netty-kerberos-proxy-auth
3 of 4 checks passed
|
This pull request has been closed and the conversation has been locked. Comments on closed PRs are hard for our team to see. If you need more assistance, please open a new issue that references this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Use the new AuthGenerator mechanism in the
Http1TunnelConnectionPoolandAwaitCloseChannelPoolMapclasses. For now, supports only using BASIC auth; Kerberos will be added in a subsequent PR.Modifications
Testing
Screenshots (if appropriate)
Types of changes
Checklist
mvn installsucceedsscripts/new-changescript and following the instructions. Commit the new file created by the script in.changes/next-releasewith your changes.License