Skip to content

Upgrading to PT 2.3 for release #4732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
erickb336 merged 6 commits into from
Jun 18, 2024
Merged

Upgrading to PT 2.3 for release #4732

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
a197791
upgrading to PT 2.3 for release
adtian2 Jun 13, 2024
8920382
Merge branch 'master' into smp-pt-2.3
adtian2 Jun 14, 2024
eda6975
Merge branch 'master' into smp-pt-2.3
adtian2 Jun 17, 2024
7437efc
reverting mistake in modifying dataparallel
adtian2 Jun 17, 2024
bd82f32
Merge branch 'smp-pt-2.3' of https://github.com/adtian2/sagemaker-pyt…
adtian2 Jun 17, 2024
5152da5
Merge branch 'master' into smp-pt-2.3
erickb336 Jun 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 27 additions & 1 deletion src/sagemaker/image_uri_config/pytorch-smp.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,8 @@
"2.0": "2.0.1",
"2.1": "2.1.2",
"2.2": "2.3.1",
"2.2.0": "2.3.1"
"2.2.0": "2.3.1",
"2.3": "2.4.0"
},
"versions": {
"2.0.1": {
Expand Down Expand Up @@ -134,6 +135,31 @@
"us-west-2": "658645717510"
},
"repository": "smdistributed-modelparallel"
},
"2.4.0": {
"py_versions": [
"py311"
],
"registries": {
"ap-northeast-1": "658645717510",
"ap-northeast-2": "658645717510",
"ap-northeast-3": "658645717510",
"ap-south-1": "658645717510",
"ap-southeast-1": "658645717510",
"ap-southeast-2": "658645717510",
"ca-central-1": "658645717510",
"eu-central-1": "658645717510",
"eu-north-1": "658645717510",
"eu-west-1": "658645717510",
"eu-west-2": "658645717510",
"eu-west-3": "658645717510",
"sa-east-1": "658645717510",
"us-east-1": "658645717510",
"us-east-2": "658645717510",
"us-west-1": "658645717510",
"us-west-2": "658645717510"
},
"repository": "smdistributed-modelparallel"
}
}
}
Expand Down
1 change: 1 addition & 0 deletions src/sagemaker/image_uris.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -686,6 +686,7 @@ def get_training_image_uri(
"p5" in instance_type
or "2.1" in framework_version
or "2.2" in framework_version
or "2.3" in framework_version
):
container_version = "cu121"
else:
Expand Down
2 changes: 1 addition & 1 deletion tests/unit/sagemaker/image_uris/test_smp_v2.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ def test_smp_v2(load_config):
for region in ACCOUNTS.keys():
for instance_type in CONTAINER_VERSIONS.keys():
cuda_vers = CONTAINER_VERSIONS[instance_type]
if "2.1" in version or "2.2" in version:
if "2.1" in version or "2.2" in version or "2.3" in version:
cuda_vers = "cu121"

uri = image_uris.get_training_image_uri(
Expand Down