Skip to content

Add generated Q Business client and integration tests#54

Merged
Alan4506 merged 2 commits into
awslabs:developfrom
Alan4506:feat/qbusiness-client
Jun 24, 2026
Merged

Add generated Q Business client and integration tests#54
Alan4506 merged 2 commits into
awslabs:developfrom
Alan4506:feat/qbusiness-client

Conversation

@Alan4506

@Alan4506 Alan4506 commented Apr 23, 2026

Copy link
Copy Markdown
Contributor

Description of changes:

This PR adds integration tests for the Q Business service client (aws-sdk-qbusiness), covering the following:

  • Non-streaming operations: create_application, get_application, delete_application, create_index, get_index, create_retriever, get_retriever, chat_sync.
  • Bidirectional event streaming operation: chat.

The test structure and patterns follow the same conventions established in the Lex Runtime V2 integration tests (PR #51), such as session-scoped conftest fixtures for resource setup/teardown.

To successfully run the tests locally, follow the steps below:

# Set up your AWS credentials, then:
cd <path-to-smithy-python>
git checkout develop && git pull
make build-py

# Set up and run Q Business integration tests
cd <path-to-aws-sdk-python>/clients/aws-sdk-qbusiness
uv venv .venv && source .venv/bin/activate
uv pip install --group test -e . 
python -m pytest tests/integration

All tests should pass.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@Alan4506 Alan4506 requested a review from a team as a code owner April 23, 2026 15:08
Comment thread clients/aws-sdk-qbusiness/tests/integration/conftest.py Outdated
Comment thread clients/aws-sdk-qbusiness/tests/integration/test_bidirectional_streaming.py Outdated
Comment thread clients/aws-sdk-qbusiness/tests/integration/__init__.py
Comment thread clients/aws-sdk-qbusiness/tests/integration/conftest.py
Comment thread clients/aws-sdk-qbusiness/tests/integration/conftest.py Outdated
Comment thread clients/aws-sdk-qbusiness/tests/integration/test_bidirectional_streaming.py Outdated
@jonathan343

Copy link
Copy Markdown
Contributor

Thanks @Alan4506!

Left some very minor comments above. All tests succeed for me locally.
I'm fine approving once the commends are addressed.

@jonathan343 jonathan343 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@Alan4506 Alan4506 merged commit ef21552 into awslabs:develop Jun 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants