Repository navigation
Fix #76: escape '--' in list item comments of the hierarchy XML - #77
Open
MartinBartolome wants to merge 1 commit into
Open
MartinBartolome wants to merge 1 commit into
MartinBartolome wants to merge 1 commit into
Conversation
SwApplication.allListItemsToXML() wrote the item text unescaped into an XML comment. A text containing '--' made the hierarchy XML invalid, so every XPath lookup failed and the hierarchy could not be stored. Replace '--' in the comment text by '- -'. The <listitem> content is unchanged.
MartinBartolome
force-pushed
the
issue/76
branch
from
October 30, 2026 08:28
89bedec to
f1f9489
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #76.
SwApplication.allListItemsToXML()wrote the item text unescaped into an XML comment. A text containing--made the hierarchy XML invalid, so every XPath lookup failed.--in the comment text by- -(SwApplication.asXmlCommentText). The<listitem>content is unchanged.SwApplicationListItemsTest: fails withSAXParseExceptionwithout the fix, passes with it.mvn testontaf-swing-server: 9 tests, 0 failures (JDK 17, target 1.8).