Fix a potential TypeException caused by None type - #668
Merged
Merged
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Collaborator
|
Sigh. The presence of this PR means that we don't have an adequate test case for this situation. |
aiuto
approved these changes
Feb 15, 2023
aiuto
left a comment
aiuto
left a comment
Collaborator
There was a problem hiding this comment.
I'll take the lack of response about adding a test as a "no".
Contributor
Author
|
Really busy these days. I will try to add some tests on the weekend. |
sqybi
added a commit
to sqybi/rules_pkg
that referenced
this pull request
Feb 17, 2023
sqybi
added a commit
to sqybi/rules_pkg
that referenced
this pull request
Feb 22, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
os.access(content_path, os.X_OK)will raise a TypeException whencontent_pathis None.f_modeis only used whencontent_pathis neither None nor empty, so I decided to move the assignment into this else-branch.Thanks @mutongx for reporting this issue.