Skip to content
This repository was archived by the owner on Mar 8, 2020. It is now read-only.
This repository was archived by the owner on Mar 8, 2020. It is now read-only.

Point to enry and github/linguist #191

Description

@smola

From @ajnavarro yesterday (more):

  • I have the necessity of know the language of the file before hand to use bblfsh
    • talk about enry on bblfsh documentation to fill that necessity

Somewhere in the documentation we should clarify that when we choose language keys, we use github/linguist as reference (languages.yml) and both enry in Go and linguist in Ruby will do the job if language detection is needed before passing to Babelfish.

Activity

  1. dennwc commented on Aug 14, 2018

    @dennwc
    Member

    This is actually not true that you need to know the language to parse files. Bblfshd will autodetect it if it's empty. Need to clarify this.

  2. smola commented on Oct 4, 2018

    @smola
    MemberAuthor

    @dennwc Sure, but when you specify a language, we use language names as defined in enry.

  3. smola commented on Oct 19, 2018

    @smola
    MemberAuthor

    when you specify a language, we use language names as defined in enry.

    This is actually not true (currently) for Bash: bblfsh/bash-driver#39 (comment)

  4. bzz commented on Nov 20, 2018

    @bzz
    Contributor

    Could somebody please help me understand, what are the action items here now?

    If that is to mention the language auto-detection + usage of enry/linguist language names on client API level - would https://docs.sourced.tech/babelfish/using-babelfish/clients be a good place for adding a new section on language detection? (Open to any other suggestions as well)

  5. smola commented on Nov 23, 2018

    @smola
    MemberAuthor

    @bzz IMHO it would be mentioning how the language field works in requests:

    Not sure if it belongs to client or to the protocol description. Or even both.

  6. bzz commented on Dec 12, 2018

    @bzz
    Contributor

    @smola I see! But could you please help me understand how is that different from what we have in https://docs.sourced.tech/babelfish/using-babelfish/babelfish-protocol#parserequest ?

    the client must provide ... the programming language in the language field (which must be one of the languages currently supported) or empty to enable auto-detection)

    From what I can see, it's:

    If that is all that's needed - will be happy to add it asap.

  7. self-assigned this
    on Dec 12, 2018
  8. smola commented on Dec 13, 2018

    @smola
    MemberAuthor

    @bzz Yeah, a mention to the key would be enough I guess. Also, mention what's the behaviour regarding case sensitiveness (or lack of it).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions