JASPER-887: Court Location Panel: Set up job to extract the data from the spreadsheet and update the table entries by ronaldo-macapobre · Pull Request #1350 · bcgov/jasper

ronaldo-macapobre · 2026-09-17T22:08:01Z

Pull Request for JIRA Ticket: JASPER-887

Issue ticket number and link

https://jira.justice.gov.bc.ca/browse/JASPER-887

Description

Implements the job that checks and parses an email containing the Court Locations. If the parsing is successful, it would replace the existing court locations in the database and persist the new ones.

Type of change

New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Local
Deploy to DEV env

Checklist:

My code follows the style guidelines of this project
I have performed a self-review of my code
I have commented my code, particularly in hard-to-understand areas
My changes generate no new warnings
I have added tests that prove my fix is effective or that my feature works
New and existing unit tests pass locally with my changes
Any dependent changes have been merged and published in downstream modules

Screen Grab

…ion job

…and update related tests

…efault

…ound.

devinleighsmith · 2026-09-23T04:46:09Z

+    }
+
+    [Fact]
+    public void GetSheet_Ignores_Unknown_Columns()


Note, this doesn't match the requirement:
the format of the spreadsheet is as expected (correct tabs and columns)

But to be fair, I don't understand the context behind that requirement. Is this really a case where we need to be strict and ignore excel documents that don't exactly conform? Or is this more of a "best effort" workflow?

I implemented the ExcelParser and ExcelWorkBook to handle generic operations to excel files in case a new data extraction feature is required in the future. The behavior right now parses the spreadsheet on "best effort" and ignore the data it doesn't recognize.

In this unit test, "Region" is not a valid column that CourtLocation model recognize so rather than throw an error, it is just ignored.

devinleighsmith · 2026-09-23T04:47:20Z

+    public static void Register(TypeAdapterConfig config)
+    {
+        config.NewConfig<ParserModel.CourtLocation, CourtLocationDto>()
+            .Map(dest => dest.IsStaffed, src => src.Staffed == "Staffed")


should this be "Staffed" or "Yes"?

The spreadsheet data has either "Staffed" or "Unstaffed". To easily handle this in the frontend, I added a boolean IsStaffed property to interpret it easier.

devinleighsmith · 2026-09-23T04:55:18Z

+        }
+
+        this.Logger.LogInformation("Court Location Attachment found.");
+        return attachments.First().Value;


we should probably get the attachment with the matching key and not just the first attachment, right? I feel like if we have multiple attachments where one has the right key this may not work.

Ah make sense. I will update the code.

devinleighsmith · 2026-09-23T04:57:27Z

        }
    }

+    public async Task<OperationResult> ReplaceCourtLocationsAsync(CourtLocationDto[] dtos)


this is potentially risky with the logic that doesn't validate missing columns/format, if we get an invalid/empty file will that clear out the court locations?

Yes, the existing court locations will definitely be overwritten. However, since this feature is only used internally by the client, the chances of uploading an incorrect spreadsheet is very low and any mistakes are easily corrected by sending the another file and rerunning the job.

devinleighsmith · 2026-09-23T04:59:47Z

Question, should we validate the sender as well? it seems like our only "security" checks are filename + subject. Since this is an open source project, could someone take down the application by crafting a malicious email attachment + expected subject?

devinleighsmith · 2026-09-23T05:01:54Z

+        return attachments.First().Value;
+    }
+
+    private async Task<CourtLocationDto[]> GetCourtLocations(MemoryStream stream)


don't see any await in here, does this need to be async?

devinleighsmith · 2026-09-23T05:02:30Z

+            .Setup(s => s.GetFilteredEmailsAsync(Mailbox, Subject, null, true))
+            .ReturnsAsync([]);
+
+        var result = _job.Execute();


you awaited this elsewhere, in this test file, should here as well.

devinleighsmith · 2026-09-23T05:04:06Z

Will approve pending responses to questions about security and column validation.

ronaldo-macapobre · 2026-09-23T19:27:12Z

Question, should we validate the sender as well? it seems like our only "security" checks are filename + subject. Since this is an open source project, could someone take down the application by crafting a malicious email attachment + expected subject?

Interesting thought. I will clarify if we could determine the sender of this email. I'll also add a file scanning step for added safety.

devinleighsmith · 2026-09-23T20:29:50Z

Question, should we validate the sender as well? it seems like our only "security" checks are filename + subject. Since this is an open source project, could someone take down the application by crafting a malicious email attachment + expected subject?

Interesting thought. I will clarify if we could determine the sender of this email. I'll also add a file scanning step for added safety.

Yes, only started thinking about that with this PR, but it's not like the JASPER inbox is VPN protected or anything like that, so as far as I know anyone could send a file to it.

ronaldo-macapobre · 2026-09-23T21:13:28Z

Question, should we validate the sender as well? it seems like our only "security" checks are filename + subject. Since this is an open source project, could someone take down the application by crafting a malicious email attachment + expected subject?

Interesting thought. I will clarify if we could determine the sender of this email. I'll also add a file scanning step for added safety.

Yes, only started thinking about that with this PR, but it's not like the JASPER inbox is VPN protected or anything like that, so as far as I know anyone could send a file to it.

I'll probably use a pattern for the sender (e.g. *@provincialcourt.bc.ca) if client doesn't want it to be "hard-coded" to a specific email. I think its better than nothing.

…ce to support email sender patterns

sonarqubecloud · 2026-09-24T17:03:56Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Ronaldo Macapobre added 10 commits September 17, 2026 21:44

Initial commit for CourtLocations implementation

f9653f3

Implement court location controller/service

025cf39

Add unit tests

6d59fe5

Remove IExcelParser

39b328d

Implement Excel parsing functionality and court location synchronizat…

905de23

…ion job

Add court_locations secret

3657c18

Refactor Excel parsing classes to use Stream instead of MemoryStream …

62d3eb6

…and update related tests

Make CourtLocation Parsel model consistent by removing empty string d…

edb3c09

…efault

Update SyncCourtLocationsJob to return successfuly when no email is f…

8f35cf4

…ound.

Cleanup

066d791

ronaldo-macapobre deployed to lz-dev September 17, 2026 22:08 — with GitHub Actions Active

ronaldo-macapobre self-assigned this Sep 17, 2026

ronaldo-macapobre added enhancement New feature or request .NET Pull requests that update .net code labels Sep 17, 2026

ronaldo-macapobre requested review from JTraill and devinleighsmith September 17, 2026 22:11

ronaldo-macapobre mentioned this pull request Sep 22, 2026

[DO NOT REVIEW] JASPER-301: Court list - See more about this location - JASPER view #1355

Draft

9 tasks

devinleighsmith reviewed Sep 23, 2026

View reviewed changes

Add antivirus scanning to SyncCourtLocationsJob and update EmailServi…

dd11228

…ce to support email sender patterns

ronaldo-macapobre deployed to lz-dev September 23, 2026 23:20 — with GitHub Actions Active

github-advanced-security Bot found potential problems Sep 23, 2026

View reviewed changes

Comment thread api/Services/EmailService.cs Fixed

Added timeout when executing regex exp

a0d70d8

ronaldo-macapobre deployed to lz-dev September 23, 2026 23:31 — with GitHub Actions Active

Use support as the sender of the court location email

98b9291

ronaldo-macapobre deployed to lz-dev September 24, 2026 16:56 — with GitHub Actions Active

ronaldo-macapobre requested a review from devinleighsmith September 24, 2026 16:57

Fix failing uni test

7f592d3

ronaldo-macapobre deployed to lz-dev September 24, 2026 17:02 — with GitHub Actions Active

Conversation

ronaldo-macapobre commented Sep 17, 2026

Pull Request for JIRA Ticket: JASPER-887

Issue ticket number and link

Description

Type of change

How Has This Been Tested?

Checklist:

Screen Grab

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

devinleighsmith commented Sep 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

devinleighsmith commented Sep 23, 2026

Uh oh!

ronaldo-macapobre commented Sep 23, 2026

Uh oh!

devinleighsmith commented Sep 23, 2026

Uh oh!

ronaldo-macapobre commented Sep 23, 2026

Uh oh!

Uh oh!

sonarqubecloud Bot commented Sep 24, 2026

Quality Gate passed

Uh oh!

This branch was successfully deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

devinleighsmith commented Sep 23, 2026 •

edited

Loading