Skip to content

chore(files): set X-Forwarded-Host on the /upload location like the others - #4373

Merged
eball merged 1 commit into
mainfrom
files/upload-forwarded-host
Nov 1, 2026
Merged

eball merged 1 commit into
mainfrom
files/upload-forwarded-host

Conversation

@pengpeng

@pengpeng pengpeng commented Nov 1, 2026 •

Copy link
Copy Markdown
Member

Every other location in the files nginx config that proxies to files-server sets X-Forwarded-Host from $host. /upload did not, so it passed on whatever the request carried. This sets it the same way as the others.

🤖 Generated with Claude Code


Note

Low Risk
Single nginx header line in deploy config; no auth or data-path logic changes, only consistent proxy metadata for uploads.

Overview
Aligns the /upload nginx proxy block with the other files-server routes by setting X-Forwarded-Host from $host.

Previously /upload only forwarded Host, X-Real-IP, and X-Forwarded-For, so the backend could see a client-supplied or missing forwarded host on upload traffic. Upload requests now get the same explicit host header behavior as /api, /system, and the rest.

Reviewed by Cursor Bugbot for commit a936eba. Bugbot is set up for automated code reviews on this repo. Configure here.

…thers

Every other location that proxies to files-server sets it from $host;
/upload passed on whatever the request carried.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@vercel

vercel Bot commented Nov 1, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
olares-docs Ignored Ignored Nov 1, 2026 2:39pm UTC

Request Review

@eball
eball merged commit f73d724 into main Nov 1, 2026
17 checks passed

This branch was successfully deployed

1 active deployment
Preview – olares — a936eba2 Deployed Nov 1, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants