Repository navigation
Keep JavaScript definition names distinct in modules and effects - #1760
Merged
Lorenzobattistela merged 6 commits intoOct 20, 2026
Merged
Conversation
oxura
changed the title
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Lorenzobattistela
approved these changes
Oct 20, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Imported
lib:valueand rootlib.valueare different checked definitions. JS currently collapses them in two places: pure module exports overwrite each other, and foreign IO handlers fail with “two effects register lib.value”. Keep canonical names in both paths, and escape generated property keys so quotes/backslashes cannot break a module.Root names and constructor tags stay unchanged. Imported export keys and foreign JS definition IDs now keep
:; this is a breaking change for hosts that called an imported def by its dotted key. No compatibility aliases.Real consumers fail before the fixes and pass after: both pure functions remain callable, and the two IO handlers print 1 then 2 under both Bun and Node. Interpreter IO and the existing prototype-key, constructor interop, Nat/F32 export and host-closure consumers pass too. Local repo/cap gate: 54/54. Remote mini-cluster gates were not run.
Closes #1758
Closes #1759
Closes #1766