Repository navigation
Conversation
Collaborator
|
Thanks for following up on the #1714 note. We're going to close this one: nothing in the repo uses FID on a preprocessor line, and the only effect today is that an unused def stays in the build (the guard is always true). That doesn't justify a second regex plus per-line directive tracking in c_ids while comp.ts is at its 66k cap, and since #1439 reshaped c_ids, a rebase would mean rebuilding the loop anyway. If a real effect source ever needs an FID presence guard, we can revisit it then. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #1714.
A presence guard used to bring its own FID target into the build, so it was always true. Preprocessor queries no longer root entries.
#definebodies still do: a macro-expanded call must keep its target.The new runtime fixture covers absent/present guards, continued/commented directives, C digraphs, and a macro call across a multiline comment. It failed in clang before the fix and now builds and prints 42.
The JS twins now use
FID(imul)to dispatch to the realMath.imul, instead of returning a constant. The C twins still invoke the Bend entry.Locally, all four affected/boundary fixtures pass checkup, the interpreter, emitted JS, and native C. No private-cluster run claimed.
Repo gate: 54/54; all caps unchanged.