Repository navigation
fix(window): decode macOS window titles as UTF-8 - #1834
Open
sebastian-griego wants to merge 1 commit into
Open
sebastian-griego wants to merge 1 commit into
sebastian-griego wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Window.opendecodes UTF-8 title bytes as Latin-1 on macOS. For example,cafébecomescafé. UsestringWithUTF8String:to read the bytes fromio_cstr, consistent withWindow.set_title.Add a regression that reads the actual native window title and closes each window. It checks Unicode (
Bend café 日本語 😀), ASCII, and empty titles. A run without a display accepts onlyENOTSUP; other open errors fail the test.Validation on macOS, based on current main
aee1b1f2:False / True / Truewith the old decoder andTrue / True / Truewith the fix. These runs used a display and inspected the actual titles.True / True / True. These runs check theENOTSUPpath because the JavaScript backend has no display.gates/repo.ts:PASS: 54 / 54.git diff --check: passed.The full cluster gates and Linux native test were not run.