Use patch-relative version ranges for first-party deps#880
Merged
Conversation
webtransport was pinned to exactly 0.4.0, which requires h2 0.9.0 and conflicts with hackney's own h2 ~> 0.10.0. Switch quic, h2 and webtransport to ~> patch ranges so 0.4.x/0.10.x/1.6.x resolve while still requiring an explicit bump for the next minor. Picks up webtransport 0.4.1, which fixes the h2 conflict. Fixes #879
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #879.
The exact pin
webtransport "0.4.0"requiresh2exactly0.9.0, which contradicts hackney's ownh2 ~> 0.10.0and makes strict resolvers (mix) refuse to install 4.4.0.Switch quic, h2 and webtransport to
~>patch ranges so the 0.4.x / 0.10.x / 1.6.x lines resolve while the next minor still needs an explicit bump:quic1.6.5->~>1.6.5h2~>0.10.0->~>0.10.1webtransport0.4.0->~>0.4.1~>0.4.1pulls in webtransport 0.4.1, which already relaxed its own h2 requirement to~> 0.10.1, removing the conflict. Cleanrebar3 compileresolves webtransport 0.4.1 / h2 0.10.1 / quic 1.6.5.