Release 4.4.1#881
Merged
Merged
Conversation
A connection from a just-completed request returns to the pool through an async checkin, so a back-to-back checkout could see the pool at max_connections and fail with checkout_timeout before the checkin landed. pool_size/max_connections now bounds the warm idle pool: checkout opens an overflow connection when none is pooled (per-host concurrency stays capped by max_per_host via load regulation), and checkin closes a connection that would grow the idle pool past its size. Updates the two pool tests that asserted the old fast-fail behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Patch release.
Dependencies (#879)
webtransport was pinned to exactly 0.4.0, which requires h2 0.9.0 and conflicts with hackney's own h2 ~> 0.10.0, breaking installation on strict resolvers (mix). First-party deps are now patch-relative ranges, picking up webtransport 0.4.1 which relaxes its h2 requirement:
Fixed: spurious checkout_timeout
A connection from a just-completed request returns to the pool through an async checkin, so a back-to-back checkout could see the pool at max_connections and fail with checkout_timeout before the checkin landed (surfaced as an intermittent Linux-only failure in hackney_recv_timeout_tests).
pool_size / max_connections now bounds the warm idle pool: checkout opens an overflow connection when none is pooled, with per-host concurrency still capped by max_per_host via load regulation, and checkin closes a connection that would grow the idle pool past its size. The two pool tests that asserted the old fast-fail behavior are updated.