Repository navigation
Closed
Labels
A-MetaAbout the project itselfAbout the project itself
Description
What problem does this solve or what need does it fill?
A clearer defined set of practices for the creation of the Migration Guides.
During the development of the 0.5 release, it became clear that the release would contain several (unintuitive) changes: #1601
The actual execution had several Problems:
- The Issue for the Migration Guide was created relatively late in
0.5s development (~3 Months after0.4and ~1 Month before0.5) - People were quick to report changes in the Issue, but few bothered to write them down for the Website.
- The Website PR (Migration Guide: 0.4 to 0.5 bevy-website#107) was created by Cart targeted the ´main´ branch. This meant that other contributors send PRs to fork
cart/bevy-websiteinstead ofbevyengine/bevy-website, which hurts their visibility. - Out of a combination of 1. and 2. not every change listed in the Issue was actually transcribed to the Website Version when
0.5finally released. After the release, PRs were still made that added missing entries: Update _index.md bevy-website#128, More migration guide bevy-website#129, Mention system ordering behavior in 0.4-0.5 migration guide bevy-website#133
What solution would you like?
- Create a dedicated
migration-guidebranch on thebevyengine/bevy-websiteRepository. Once the next Release happens that Branch can then be merged in the main branch. This solves the Issues:- 1.) New entries for a new release can always be created, even if another version just released
- 3.)
bevyengine/bevy-websiteis more visible than a private Fork - and 4.).
- Add a
Needs Migration GuideLable to thebevyengine/bevyRepository, that's applied to PRs.- This stops the need to create a
0.x -> 0.y Migration GuideIssue for every Release. - A PR Author should not be required to write the Migration Guide himself, just encouraged. This shouldn't be annoying bureaucracy.
- This stops the need to create a
What alternative(s) have you considered?
- Do Nothing
- The same issues mentioned above will reappear.
- Only add a
migration-guidebranch tobevyengine/bevy-website- Could be done in the short-term, until Label revamp discussed in Bevy Development Process #2256 happens.
Reacted by Federico Rinaldi and Alice Cecile
Metadata
Metadata
Assignees
Labels
A-MetaAbout the project itselfAbout the project itself
Activity
cart commentedon Jul 9, 2021
I love all of these ideas! I've done both of your suggestions:
Thanks for putting this together.
mockersf commentedon Jul 9, 2021
about the 0.6 release, I opened bevyengine/bevy-website#134 after the first breaking change
cart commentedon Jul 9, 2021
Yupyup. To adapt to this I think it makes sense to change your prs base branch to migration-guide. And then we can merge into that as soon as your changes are ready.
cart commentedon Jul 9, 2021
We might still need a centralized tracking issue to ensure things aren't dropped and ensure people don't step on each other's toes.
cart commentedon Jul 9, 2021
But I think the per-pr tags should be considered the "source of truth".
cart commentedon Jul 9, 2021
Also breaking changes aren't the only criteria for migration guides. I think we should also include "changes in recommended practices", such as #2398.
.system()can still be used, but we should still encourage people to remove it. I just tagged that pr.