Skip to content

Custom Materials with Atomic Counter #7030

Closed

Description

@DasLixou

What problem does this solve or what need does it fill?

After #6988 I've questioned myself if it would be also possible to make custom materials use atomic counter for their AsBindGroup, instead of TypeUUID.

What solution would you like?

Make the AsBindGroup derive also increasing the atomic counter, so that lines like

#[uuid = "f690fdae-d598-45ab-8225-97e2a3f056e0"]
don't need to exist anymore.

Activity

  1. added
    C-FeatureA new feature, making something new possible
    S-Needs-TriageThis issue needs to be labelled
    on Dec 25, 2022
  2. james7132 commented on Dec 25, 2022

    @james7132
    Member

    That line is for the TypeUuid derive. It's required to support using it as an asset. The use case is entirely different and definitely needs a stable independent unique ID that is the same across compilations and executions of the same binary. I don't think we can get rid of that without the stable type name as a replacement for TypeUuid.

  3. added
    A-ReflectionRuntime information about types
    A-RenderingDrawing game state to the screen
    and removed
    S-Needs-TriageThis issue needs to be labelled
    on Dec 26, 2022
  4. DasLixou commented on Dec 26, 2022

    @DasLixou
    ContributorAuthor

    Oh I See.. should this be closed?

  5. james7132 commented on Jan 9, 2023

    @james7132
    Member

    Probably should. I don't think this issue is actionable. Feel free to reopen if there is something tangible we could do to improve our use of UUIDs here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    A-ReflectionRuntime information about typesA-RenderingDrawing game state to the screenC-FeatureA new feature, making something new possible

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions