Repository navigation
Rename App::add_plugins to App::add_plugin_group #7631
Description
What problem does this solve or what need does it fill?
This method is very easily and subtly typo'd and regularly bites new users.
What solution would you like?
Rename it to add_plugin_group.
Additional context
See #7630 for an example, but I've seen this regularly.
Reacted by Logic, RobertoSnap and xgbwei
Activity
CmPons commentedon Feb 12, 2023
Hey, I'm not sure if this is a good first issue, but I'm starting to look into this. @alice-i-cecile I have the changes ready, just trying to test it right now.
alice-i-cecile commentedon Feb 12, 2023
Should be easy to implement! The real trick is convincing everyone that it's a good change :)
alice-i-cecile commentedon Feb 14, 2023
I think we should consider fixing this upstream by improving the diagnostics instead. There's not a clear argument for either API (as called out by Cart in #7643), and this is a Rust wide problem with a confusing / misleading diagnostic.
BD103 commentedon Mar 4, 2024
With
add_pluginbeing deprecated and onlyadd_pluginsremaining, I'm going to close this as not planned.