Skip to content

Don't auto insert on the extract schedule - #11669

Merged
james7132 merged 1 commit into
bevyengine:mainfrom
hymm:extract-no-auto-sync
Feb 3, 2024
Merged

james7132 merged 1 commit into
bevyengine:mainfrom
hymm:extract-no-auto-sync

Conversation

@hymm

@hymm hymm commented Feb 3, 2024

Copy link
Copy Markdown
Contributor

Objective

  • In Auto insert sync points #9822 I forgot to disable auto sync points on the Extract Schedule. We want to do this because the Commands on the Extract Schedule should be applied on the render thread.

@hymm hymm added this to the 0.13 milestone Feb 3, 2024
@hymm

hymm commented Feb 3, 2024

Copy link
Copy Markdown
Contributor Author

This still needs to be tested with tracy to check that it works.

@re0312

re0312 commented Feb 3, 2024

Copy link
Copy Markdown
Contributor

works fine !
uTools_1706930907365

@Elabajaba Elabajaba left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@james7132
james7132 added this pull request to the merge queue Feb 3, 2024
Merged via the queue into bevyengine:main with commit a919cb0 Feb 3, 2024
@hymm
hymm deleted the extract-no-auto-sync branch February 4, 2024 22:57
tjamaan pushed a commit to tjamaan/bevy that referenced this pull request Feb 6, 2024
# Objective

- In bevyengine#9822 I forgot to disable auto sync points on the Extract Schedule.
We want to do this because the Commands on the Extract Schedule should
be applied on the render thread.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants