[Brezak]

Objective

Remove color specialization from SpritePipeline after it became useless in #9597

Solution

Removed the COLORED flag from the pipeline key and removed the specializing the pipeline over it.

---

Changelog

Removed

• SpritePipelineKey no longer contains the COLORED flag. The flag has had no effect on how the pipeline operates for a while.

Migration Guide

• The raw values for the HDR, TONEMAP_IN_SHADER and DEBAND_DITHER flags have changed, so if you were constructing the pipeline key from raw u32s you'll have to account for that.

[github-actions]

Welcome, new contributor!

Please make sure you've read our contributing guide and we look forward to reviewing your pull request shortly ✨

[github-actions]

It looks like your PR is a breaking change, but you didn't provide a migration guide.

Could you add some context on what users should update when this change get released in a new version of Bevy?
It will be used to help writing the migration guide for the version. Putting it after a ## Migration Guide will help it get automatically picked up by our tooling.

[alice-i-cecile]

This is a breaking change because we changed the pipeline keys, correct?

[Brezak]

Appears to be. Question then is. Will the removal impact anybody. The flag currently doesn't affect the shader at all.

[alice-i-cecile]

Looks like they may need to move their DEBAND_DITHER code around to compensate right? I have no problem with it being a breaking change, I just want a one sentence migration guide in the PR description :)

[Brezak]

Updated the PR description to include a change log and migration guide.

[james7132]

Was the shaderdef not being used in the shader?

[Brezak]

Was the shaderdef not being used in the shader?

No. The pr linked in the description removed it.